Add support for CSS' named colors. about garden HOT 5 CLOSED

Nice!

They should be unique within the namespace, so how about using keywords? The less string processing the better :-)

What about naming conventions? Should it be :alice-blue (Clojure naming convention" or :aliceblue?

from garden.

Map lookup is pretty trivial, and either way Garden has to convert :blue, "blue", and 'blue into a commonform key. But yeah they probably might as well be keywords.

Since those colors map to literal CSS values, it would be confusing if people had to guess whether it's :sea-shell or :seashell when they already know what the browser expects.

from garden.

Oh yes, I realize this is much more of a form thing than a performance thing. Keywords could have some fringe benefits though, being that they are functions in relation to maps.

I think you're right with regards to the naming. Being a DSL for CSS, it's better to keep naming aligned with CSS.

from garden.

So this is one of those things I definitely thought about while working on the color namespace. The reason I left it out was because I wasn't sure how best to handle the situation.

Perhaps these colors could be defined in the color namespace and the map could reference them. A few things might need to be altered to get something like (+ :red :blue) working though.

In general the color namespace definitely needs some love. At the moment it's mostly a strait port of Sass' color module and I feel like we can do much better. @weavejester has done some work in the space with crumpets and I feel like his work is closer to how the namespace should look.

Overall I would like to see this added. Let's continue to brainstorm as this is definitely something we should have.

from garden.

Partial solution now in master (color/from-name "red").

from garden.