rem unit support about garden HOT 7 CLOSED

No. The reason I had it commented out was to prevent warnings with (require '[garden.units :refer :all]) and honestly I just forgot to uncomment it. It's probably perfectly fine to uncomment it since I would (hopefully) assume people know how to write Clojure. :-)

While on the subject, the rem unit is not supported in some older browsers such as IE8 which is still widely used AFAIK. I'm wondering if Garden should be involved in helping with that at all? That is, perhaps allowing the user to specify the default rem value in px and have the compiler emit px instead of rem for that value. It seems tedious to have to worry about fallbacks. What do you think?

from garden.

@jeluard I'm adding you to collaborators list so you don't have to maintain a separate fork. :-)

from garden.

Thanks! I promise I won't do bad things :) Now I will probably go ahead and make this simple change after some tests.

from garden.

Don't worry man, I trust you know what you're doing! Just keep me in the loop. 👍

from garden.

Having sane fallback whenever possible seems like a good idea. Is there some weird trick in this case? Or are you thinking always replacing rem by px?

ClojureScript support (assuming generation is done browser side) definitively allows that kind of things as you can directly check if a property is supported (maybe trickier to check for units support).

from garden.

Actually, it appears that may be a bad idea. Converting rem transparently to px will definitely result in issues where the width of something should be dynamic as in border-width. You can see an example of what I'm talking about here. If you change the display so the output is on the left and then resize it horizontally you can see the border width actually shrinks/grows. You can also see there is some JavaScript code in the example which demonstrates how one might detect the support of a unit.

from garden.

Thanks for the link!

from garden.