Comments (4)
First, I want to say that I like garden.
Thanks! I appreciate it. :)
A clojurescript port would be very nice... using the library for in-browser dynamic CSS generation...
I think you're right. This is a good idea and eventually I'd like to see this happen.
Could you please allow for generic media queries to be made so that vendor specific media queries can be created?
Yes, this is definitely in order. The problem is I made media queries too strict (see here) basing them solely on what was put forward in the specs.
This morning I also discovered it's not possible to express something like only screen
.
Taking these two problems in to account I think it's probably best that Garden avoid the business of validating media query properties and just focus on the semantics of values. This would solve your issue and (potentially) prevent others like it in the future.
I'll get started on a patch and keep an eye on this issue. Please let me know if you spot anything else.
from garden.
Thanks for the timely response.
I think it's probably best that Garden avoid the business of validating media query properties
I agree. Even if you had a clojure CSS3 parser that was fully compliant with W3 standards that you could use for proper validation, you would still need the parser to recognize CSS3 vendor-specific grammar subsets... e.g. maybe the parser would accept a keyword/value pair like {:include-grammar "webkit"} or {:include-grammar "mozilla"}. Better to leave validation to another library!
from garden.
OK. That should do it. I've pushed up a new version of the library so we should be good to go.
Thanks for bringing this to my attention! I appreciate it.
from garden.
Thanks for making media queries like this possible:
repl> (css (at-media {:screen true :min-device-width (px 1080) :orientation :portrait :-webkit-min-device-pixel-ratio "3"} [:html {:width (px 1080)}]))
"@media screen and (min-device-width:1080px) and (orientation:portrait) and (-webkit-min-device-pixel-ratio:3){html{width:1080px}}"
from garden.
Related Issues (20)
- defcssfn don't behave as documented HOT 2
- Incorrect CSS emitted for inner media queries HOT 6
- Link broken for Tutorial and example in Wiki HOT 6
- how to supply the value to grid-template-area? in css it is multiple strings... HOT 3
- Changelog since 1.3.6 HOT 1
- Property order is different in output CSS, renders incorrectly in browser HOT 7
- `as-hex` taking into account Alpha value
- No `fr` unit
- Question about defining multiple style maps HOT 6
- Add support for container queries HOT 3
- Incorrect CSS emitted for "&" parent selector
- defcssfn is not defined in cljs or cljc
- `ClassNotFoundException` thrown when running tests on Java 11
- Warning about `garden.color/abs` shadowing `clojure.core` output when using Clojure 1.11.0 HOT 1
- `::marker` pseudo element isn't supported HOT 2
- Release request, to prevent repeated shadowed-var warnings in the REPL HOT 13
- Incorrect handling of selectors HOT 1
- Incorrect css generation HOT 1
- content: " " produces wrong output HOT 5
- Feature request: Support for cascade layers HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from garden.