v1.19.5 LSLib Build issue about lslib HOT 9 CLOSED

Apparently I have some commits that are entirely missing from the repo, the LSF conversion patch being one of them. I'll try to figure out wtf is up

from lslib.

I can get that to compile if I change to:

meta.CompressionFlags = CompressionHelpers.MakeCompressionFlags(Compression, CompressionLevel);

from lslib.

Additionally, in SavegameHelpers.cs (line 74), I had to change the following:

        var rsrcWriter = new LSFWriter(rewrittenStream)
        {
            Version = conversionParams.LSF //,
     //       MetadataFormat = LSFMetadataFormat.None
        };

as MetadataFormat is not defined.

from lslib.

Something happened here I think that introduced the build issue(s).

22e7306#diff-18689dd18950168d90dbf455db03c0aba60890fe3f656baf5cc4ae6c6f0122cb

This is a bit concerning because the currrent source does not appear to be synced with the 1.19.5 Release binary.

from lslib.

Yeah, that is what it looks like to me too. There is a check-in that is partially hosed....

from lslib.

I think it should be fine now!

from lslib.

Ok, I will do a fresh build of the latest...

Hmm.... I am not seeing anything recently checked-in to Master or v1.19.5.

Were you able to make the changes retroactively?

....

I guess you were because I can see changes made after extracting the latest zip-file repo image.

Quite a number of changes, much greater than the previous encountered compiler errors....

from lslib.

From a "clean" build from a pristine directory, I encounter the following:

------ Build started: Project: LSLib, Configuration: Release Any CPU ------
GPPG: sending output to C:\DevProjects\lslib-master(1)\lslib-master\LSLib\LS\Story\GoalParser\Goal.yy.cs
GPPG: sending output to C:\DevProjects\lslib-master(1)\lslib-master\LSLib\LS\Story\HeaderParser\StoryHeader.yy.cs
C:\DevProjects\lslib-master(1)\lslib-master\LSLib\LS\Story\HeaderParser\HeaderParser.cs(24,25,24,38): error CS0246: The type or namespace name 'HeaderScanner' could not be found (are you missing a using directive or an assembly reference?)
C:\DevProjects\lslib-master(1)\lslib-master\LSLib\LS\Story\GoalParser\GoalParser.cs(79,29,79,40): error CS0534: 'GoalScanner' does not implement inherited abstract member 'AbstractScanner<object, CodeLocation>.yylex()'
Done building project "LSLib.csproj" -- FAILED.

I encountered this previously as well, but was able to somehow get around it by building again.

I think there is possibly something in the .cs file generation that is somewhat wonky and possibly not set up correctly... and using the outputs from a previous build and not the current build.

from lslib.

Other than the above regarding mysterious double build requirement, I guess this issue can be closed.

from lslib.