Comments (1)
philips77
commented on July 17, 2024
Hi,
That's so true. The lib has zero tests and it's, as you wrote, written in non-testable way. I'm open for any proposals.
So far, testing on our side is based on manual tests on multiple phones, apps and devices + issues on GitHub, but that's far from ideal. Changing one thing may easily break others. There are other issues with the lib. It has a lot of legacy code. Initially it was written inside nRF Toolbox, used for 2-3 profiles. Then it was extended to all, then externalized, now the version 2 with changed API and deprecated the old one. But still the BleManager is around 2000 lines too long, should be cut, request implementation should be moved to requests, etc. Then it should be implemented with tests in mind, where each module should be testable separately. A lot of work, but I can't wait to start. To be honest, I don't want to add tests to this version, as it will for sure change in some time.
But some small changes, as you said, are very welcome. Please, fork the repo and send us PR. I'm sure that adding a constructor with the handler will not be enough and I have no time to look into it right now.
from android-ble-library.
Related Issues (20)
- Library DefaultMtuSplitter is splitting incorrectly for android OS 14 HOT 8
- How to Catch Exception with RequestFailedException HOT 1
- Ask a question, thank you HOT 1
- Want to get the characteristic on which the data was received for the characteristics I have subscribed to get notified for HOT 2
- Concurrent modification exception while notifying device disconnected
- Disconnect not working on various Samsung devices HOT 2
- No response from writeCharacteristic HOT 3
- Question: Will this allow me to send HCI Level Commands? HOT 1
- I stoped receiving notifications even when i have still not get all data HOT 23
- Sometimes causing system Bluetooth to crash. HOT 4
- Notification does not clear after setup a device HOT 3
- Connection interval changes on its own HOT 3
- OTA upgrade problem HOT 1
- Cannot connect the BLE device HOT 6
- A couple of questions, possibly bugs HOT 4
- BLE Scanner stop working
- Scanner issue
- Internal write characteistic and dead system exception HOT 1
- Issue with auto connect HOT 1
- Need help with configuration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-ble-library.