Comments (3)
Thanks for asking! I was just about to ask about this myself. My vote would be for both 2 and 3.
I found myself wanting access to these things in my BleManager
subclass:
- The
readRssi()
method - The
createBond()
method - The
Context
passed in to the constructor, which I need in order to go and get some singletons in my app.
from android-ble-library.
Our implementation follows 1)
On the one hand, it helps in keeping BT implementation details contained in 1 class, and we can expose operations with semantic meaning in our domain. On the other hand, it does end up becoming a God class. Our BleManager implementation is ~550 lines with very little tests (see #45)
Implementing 2) would helping in having smaller, domain-specific Ble classes if we were able to keep a single queue request. As I'm thinking it right now, we'd have a singleton BleManager instance and per-feature wrappers over it. This'd make smaller classes with easier testing.
SensorBleManager @Inject constructor(private val bleManager) {
fun enableVibration(){
bleManager.writeCharacteristic(...).enqueue()
}
}
Which methods are you considering to make non-final? What would be the goal? Is it to facilitate testing or are there other reasons?
from android-ble-library.
Let's leave the testability to #45.
I was thinking about definaling methods that return Requests, e.g. writeCharacteristic(...)
, etc.
This may be useful if the BleManager
instance is to be used as a generic BLE controller, not as a device API. Currently, to expose such method, you need to add some prefix/sufix to the method name, which isn't very big deal, but makes it uglier. I found it useful in 2 cases, as far as I remember, where I wanted to call those methods from outside of manager. In that case I had a TestImpl, which just had the logic of which ble operations should be done. I didn't want to include it in BleManager for some reason.
Regarding having smaller domain-specific classes, I was rather thinking about allowing to add "modules" to the manager, responsible for some part of the logic. For example, DFU module, Battery module, etc.
Currently, what we do in nRF Toolbox, is just extending the BleManager with for example Battery logic, and then extending this in other profiles. I'm not yet sure the module approach is feasible, would it increase or decrease testability, but at least would split the class logic.
So far I'm (almost) convinced to make request operations non-final. Then exposing readRssi
or createBond
is straightforward.
from android-ble-library.
Related Issues (20)
- Mismatch Java version in sample apps and the library HOT 2
- Server closes all connections with error 0x101 HOT 1
- Android is moving bluetooth scan client to opportunistic more than it should HOT 2
- Send data over 10k charcter HOT 2
- Connection retries block on the main thread HOT 8
- Connection state is not updated when cancelled during the thread sleep time HOT 1
- NullPointerException in BleManagerHandler$3.onConnectionStateChange
- Devices are not reconnecting after upgrade from 2.6.1 to 2.7.0 HOT 3
- Question about support of this lib and the new one HOT 1
- Is there any adaptation for Android 14? HOT 1
- What would cause GATT services to be invalidated on previously bonded peripherals? HOT 2
- Null reference exception when calling disconnect HOT 2
- Sometimes onServiceDiscoverd is not called when connecting. HOT 1
- Samsung Tab S6 Lite: Connection Parameter Negotiation HOT 1
- Catch SecurityException from setCharacteristicNotification HOT 2
- NullPointerException android.bluetooth.BluetoothGattServer.cancelConnection(android.bluetooth.BluetoothDevice)' on a null object reference HOT 3
- Library DefaultMtuSplitter is splitting incorrectly for android OS 14 HOT 8
- How to Catch Exception with RequestFailedException HOT 1
- Ask a question, thank you HOT 1
- Want to get the characteristic on which the data was received for the characteristics I have subscribed to get notified for HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-ble-library.