.chcpignore file doesn't work with Windows about cordova-hot-code-push-cli HOT 6 CLOSED

me too, directory ignore work not good,
it is 'recursive-readdir' use matchBase:true for minimatcher

but , if no matchBase:true, it become like this:
**/**.map **/libs/** **/workers/** **/manifest.json **/deviceUpdate/** **/chcp.json **/chcp.manifest **/package.json **/node_modules/**

not view good,but work

from cordova-hot-code-push-cli.

Understood, thanks for the feedback. I don't have a Windows machine at the moment, so it will take some time to get one...

from cordova-hot-code-push-cli.

I have the same problem on Linux.

I needed to add **/ before all my paths in .chcpignore, e.g.:

**/www/css/uria.css

The reason is that readdir-recursive is given an absolute path (process.cwd() + 'www') and is given a list of relative paths by .chcpignore.

I think the list of ignored entries should be prefixed with process.cwd(), so readdir-recursive can properly ignore them.

Something (dirty) like:

      for(var i = 0; i < this.__ignoredFiles.length; ++i) {
        this.__ignoredFiles[i] = path.join(process.cwd(), this.__ignoredFiles[i]);
      }

in src/context.js

I think we could also ignore lines beginning with a # so we could "properly" insert comments in our .chcpignore file (just like we do with .gitignore files, to eventually explain why something is ignored)

from cordova-hot-code-push-cli.

Thanks for the input!

from cordova-hot-code-push-cli.

I think we could also ignore lines beginning with a # so we could "properly" insert comments in our .chcpignore file (just like we do with .gitignore files, to eventually explain why something is ignored)

Comments support is added in v1.1.0.

The issue is not yet fully fixed, so keeping it open.

from cordova-hot-code-push-cli.

👋 Hi! Thank you for your interest in this repo.

😢 We are not using nordnet/cordova-hot-code-push-cli anymore, and we lack the manpower and the experience needed to maintain it. We are aware of the inconveniece that this may cause you. Feel free to use it as is, or create your own fork.

🔒 This will now be closed & locked.

ℹ️ Please see #79 for more information.

from cordova-hot-code-push-cli.