make it easy to use px instead of rem about nordnet-ui-kit HOT 10 CLOSED

For internal use cases that's fine, but if external consumer will be asked to build sass templates if they don't use rem, then it can be a problem

from nordnet-ui-kit.

Why wouldn't the proposed solution work for external consumers?

$use-rem: false;
@import '~nordnet-ui-kit/src/button/button';

I'd need to add an index.scss file that would allow doing it on the bundle as well though.

from nordnet-ui-kit.

We could of course also prebuild px versions and include them in the dist folder, should be pretty easy using sass-loader environment variables.

from nordnet-ui-kit.

Why wouldn't the proposed solution work for external consumers?

if they are not using sass themself, then they would need to add node-sass to their deps and wait for it to install and to process their css every time they change smth.

I'd need to add an index.scss file that would allow doing it on the bundle as well though.

that would be the best solution

from nordnet-ui-kit.

That's a valid point, if they want to make any other changes to the UI kit they'd have to do that anyway but I get where you're coming from. Adding an index.scss file would also require that.

Do you prefer the idea of including prebuilt px versions @iamstarkov? That's what I'm leaning towards right now.

from nordnet-ui-kit.

prebuilt versions is fine.

bootstrap also provides basic css build for simple usage and sass files for advanced one

from nordnet-ui-kit.

take a look at d402470 @iamstarkov, now it'll build a px version of every entrypoint. What do you think?

from nordnet-ui-kit.

seems like a good solution

from nordnet-ui-kit.

is it published already?

from nordnet-ui-kit.

yes it is

from nordnet-ui-kit.