Giter VIP home page Giter VIP logo

Comments (15)

robpvn avatar robpvn commented on June 28, 2024

I see that this is an automated message, but the point is good. (I don't know how this project got registered with Bower when we don't have a bower.json to begin with.) We could get around to this some day. First we will need to start making proper tagged releases in git, and marking the Leaflet versions they depend on.

Actually, before that Leaflet will have to start making Bower-compatible releases since the plugin is meaningless without Leaflet. (https://github.com/Leaflet/Leaflet/blob/18be02fbba820d9a2f012c5a0460e92fb7a960aa/FAQ.md#misc) 🍃

from leaflet-minimap.

timgluz avatar timgluz commented on June 28, 2024

Ok, thanks! Good to know.

Can you also contact Bower guys and ask how you will get authorship for this package on Bower registry?

from leaflet-minimap.

reiz avatar reiz commented on June 28, 2024

Totally agree on that. Having a package manager without tags and versions will not work out ;-)

from leaflet-minimap.

robpvn avatar robpvn commented on June 28, 2024

OK, so Bower registration works on a completely unauthenticated, first-come first-serve basis with no possibility of editing mistakes, and noone owns a package once it has been registered. Changes to them can only be made by a manual database edit requested in the world's longest GitHub issue. I don't think that is the best system, to put it that way, but at least our package seems to be correctly defined.

from leaflet-minimap.

reiz avatar reiz commented on June 28, 2024

The first time I heard about bower.io I was totally enthusiastic. But then I took a closer look and as package manager it's pretty poor. I don't think that a package manager should be based on tags at GitHub. RubyGems is not perfect but still more robust as a backend.
On the other side I don't know why each language has his own package manager. They all do kind of the same. There should be a language agnostic package repository with a clean REST API. It should have multiple clients, because all the language specific things should be handled on the client anyway.

from leaflet-minimap.

robpvn avatar robpvn commented on June 28, 2024

I see from the 0.7.3 changelog for Leaflet that they've included bower support a while now. Might be time to revisit this issue now.

from leaflet-minimap.

reiz avatar reiz commented on June 28, 2024

I just checked out the changes, but there is still no bower.json file in the root directory. We track the project anyway, but as long there is now bower.json file we have no information about dependencies, licenses, description, authors and so on.

from leaflet-minimap.

Xennis avatar Xennis commented on June 28, 2024

+1 for a bower.json

from leaflet-minimap.

deeg avatar deeg commented on June 28, 2024

+1 for bower support!

from leaflet-minimap.

deeg avatar deeg commented on June 28, 2024

Is there anything we can do to help with bower support?

from leaflet-minimap.

robpvn avatar robpvn commented on June 28, 2024

I've added a bower.json, so I think things should be available now soon. (Someone had already registered this repo in the bower registry with the correct git address, so I suppose things should be showing up correctly now that the bower.json is in place.)

@deeg: If you want to help, try using bower to install leaflet-minimap and see if it all works properly. If something is wrong with the bower.json, pull requests are welcome.

from leaflet-minimap.

reiz avatar reiz commented on June 28, 2024

Cool! Many THX for the bower.json :-)

from leaflet-minimap.

deeg avatar deeg commented on June 28, 2024

It is working now, thanks. I do suggest adding to the readme about how to run the command to install it, since it is all lower case while this repo as caps.

Also I think it is pretty good practice to have a version number in your bower.json file if you want to add one.

from leaflet-minimap.

robpvn avatar robpvn commented on June 28, 2024

The spec actually says that a version number is deprecated and ignored, so I'm happy to not have to mess about with updating that manually when I npm version major/minor/patch.

I can put somtehing in the readme!

from leaflet-minimap.

deeg avatar deeg commented on June 28, 2024

Ah, thanks for letting me know!

from leaflet-minimap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.