IEnumerable vs List about shopifysharp HOT 1 CLOSED

Thanks for the kind words, Dan! I feel your pain on having to call .ToList() constantly, I end up doing that a lot in my own apps and it can get tedious pretty quick. The only reason I prefer to return IEnumerables is to make it as easy as possible for the end users to turn it into whatever they need. In most cases that will be a list like we're used to, but some devs might need to turn it into an IQueryable, a Collection, or some other custom implementation.

There are some (small) perf improvements when using IEnumerables, though I doubt many Shopify devs will run into that. The biggest advantage is just returning the least-derived interface possible so we can turn it into whatever we need as easily as possible.

That said, I would bet that most of us using this lib are calling .ToList() on the results, so I would definitely be open to converting the results to a list in the future.

It would have to wait for another major release, e.g. 3.0, so if anybody wants to chime in either for or against converting everything to a List between now and then, please do.

from shopifysharp.