Investigate supporting .NET Core projects. about shopifysharp HOT 8 CLOSED

After tinkering with .NET Core and trying to add support to ShopifySharp, it looks like we won't be able to do so until the RestSharp dependency adds support itself. They're tracking that right here.

from shopifysharp.

@nozzlegear Posted a bounty to help kick-start this 😄

For the bounty developer, the goal of this bounty is to upgrade this library to support .net core. PR must be accepted to be considered complete.

from shopifysharp.

In the lamest change ever, apparently Microsoft has decided to revert the project.json (😖) and go back to .csproj. Not sure exactly when this will happen, though.

from shopifysharp.

Here's a guide for migrating a library to .NET Core.

from shopifysharp.

Yay! This is going to be huge for my startup 😄 Please keep this thread up to date with how you progress.

from shopifysharp.

Would also very much like to see this project gain .NET Core/Standard support. Is RestSharp currently the only dependency that doesn't support .NET Standard? Once the dependencies are sorted the process of converting the project to .NET Standard should be quite easy. Also, as I've seen a previous posted raise concearn I just wanted to say that .NET Standard libs can be used from both .NET Core and .NET Framework - so there is no issue of making sure it still supports .NET Framework.

from shopifysharp.

Hey @tomeo, thanks for clarifying that! I haven't used any .NET Standard libs (to my knowledge) yet in a Framework project, so wasn't sure if they'd work together out of the box.

RestSharp was the only dependency that didn't support dotnet standard, and it's already been replaced with Flurl in the 4.0 branch. I've got a list of issues and features that I'm working through before that branch gets merged in and published, but you can track the progress in the 4.0 pull request and even use the current dotnet standard version by downloading the artifacts from AppVeyor.

from shopifysharp.

.NET Core support has been merged into the master branch! I'm going to be publishing it on Nuget by Friday evening.

from shopifysharp.