Some notes on Order Risks about shopifysharp HOT 5 CLOSED

Thanks for reporting this! I've run into the same problem in a few other objects where there are fields that are undocumented but seem to have useful values. I prefer to leave out undocumented properties, since Shopify could remove them at any time. Do you think leaving merchant_message out would be safe, or do you think it would break your app?

from shopifysharp.

I originally left it out, then put it in when I got an error - you would at least need to account for the field when deserializing.

There are a few cases where the values are different, and I dont think I've seen the value from message in the admin, just the value from merchant_message when they are different. One option would be to add a property that returns merchant_message if it is not null, message otherwise. In my Order Risk implementation, it is the same as the rest of the properties, and I check both in my app.

"message": "The Minfraud score (99.0) was above the threshold."
"merchant_message": "There is a high risk of this order being fraudulent. Shopify's fraud analysis has detected details that appear suspicious. Contact the customer to validate the order."

"message": "Customer was using a high risk web proxy to connect to the internet."
"merchant_message": "The customer used a high risk Internet connection (web proxy) to place this order."

"message": "Credit card associated with fraudulent transactions."
"merchant_message": "The customer's credit card used for this order has been associated with fraudulent transactions."

from shopifysharp.

I just noticed you started on this and have some more notes

For source, I've seen values "Internal" and "Gateway"

For merchant_message, I would add a note that it is not possible to set the value directly using the API, but if something else sets it differently, it is the message shown on the admin, not message

from shopifysharp.

Thanks! I've added 'Internal' and 'Gateway' to the list of known values, and added your notes on the merchant message.

from shopifysharp.

Order Risks are now available in ShopifySharp v3.1.0. Thanks!

from shopifysharp.