Shipping address field needs to be nullable about shopifysharp HOT 3 CLOSED

Hey @John-Streckfuss, thanks for creating this issue. Could you provide a little more background on what errors you're getting? The class should already be nullable by default and I'm not seeing any exceptions on my end when testing it.

from shopifysharp.

In the shopify order shipping address shouldn't the shipping address be defined like this?

Original Not Nullable:
///

[JsonProperty("shipping_address")]
public ShopifyAddress ShippingAddress { get; set; }

Nullable:
///

[JsonProperty("shipping_address")]
public ShopifyAddress? ShippingAddress { get; set; }

from shopifysharp.

Sorry it took so long to get back to you @John-Streckfuss, I've been super busy and haven't had a chance to get much work done on this lib. Classes in C# are already nullable, and the compiler won't actually let you mark one as explicitly nullable with ?. If the shipping_address field is null, the ShippingAddress property should automatically be null too.

Do you have a screenshot or log for the errors you're getting from this? Right now I'm not able to pinpoint anything, but it's possible I'm not quite understanding the problem.

from shopifysharp.