Giter VIP home page Giter VIP logo

Comments (13)

usr110 avatar usr110 commented on August 29, 2024

The data is missing in lines data - lots of variables are missing. I believe new data is needed to be created for Cambridgeshire.

colnames(l@data)
[1] "plan" "start" "finish" "length" "time" "waypoint"
[7] "change_elev" "av_incline" "co2_saving" "calories" "busyness" "id"

It should have these columns - taken from kent:

colnames(l@data)
[1] "id" "Area.of.residence" "Area.of.workplace"
[4] "All" "light_rail" "Bus"
[7] "Taxi" "Motorbike" "Car_driver"
[10] "Car_passenger" "Bicycle" "Foot"
[13] "Other" "govtarget_slc" "govtarget_sic"
[16] "govtarget_slw" "govtarget_siw" "govtarget_sld"
[19] "govtarget_sid" "gendereq_slc" "gendereq_sic"
[22] "gendereq_slw" "gendereq_siw" "gendereq_sld"
[25] "gendereq_sid" "dutch_slc" "dutch_sic"
[28] "dutch_slw" "dutch_siw" "dutch_sld"
[31] "dutch_sid" "ebike_slc" "ebike_sic"
[34] "ebike_slw" "ebike_siw" "ebike_sld"
[37] "ebike_sid" "base_sldeath_webtag" "base_slvalue_webtag"
[40] "govtarget_sldeath_webtag" "govtarget_slvalue_webtag" "govtarget_sideath_webtag"
[43] "govtarget_sivalue_webtag" "gendereq_sldeath_webtag" "gendereq_slvalue_webtag"
[46] "gendereq_sideath_webtag" "gendereq_sivalue_webtag" "dutch_sldeath_webtag"
[49] "dutch_slvalue_webtag" "dutch_sideath_webtag" "dutch_sivalue_webtag"
[52] "ebike_sldeath_webtag" "ebike_slvalue_webtag" "ebike_sideath_webtag"
[55] "ebike_sivalue_webtag" "base_sldeath_heat" "base_slvalue_heat"
[58] "govtarget_sldeath_heat" "govtarget_slvalue_heat" "govtarget_sideath_heat"
[61] "govtarget_sivalue_heat" "gendereq_sldeath_heat" "gendereq_slvalue_heat"
[64] "gendereq_sideath_heat" "gendereq_sivalue_heat" "dutch_sldeath_heat"
[67] "dutch_slvalue_heat" "dutch_sideath_heat" "dutch_sivalue_heat"
[70] "ebike_sldeath_heat" "ebike_slvalue_heat" "ebike_sideath_heat"
[73] "ebike_sivalue_heat" "base_slco2" "govtarget_slco2"
[76] "govtarget_sico2" "gendereq_slco2" "gendereq_sico2"
[79] "dutch_slco2" "dutch_sico2" "ebike_slco2"
[82] "ebike_sico2" "Rail" "dist"
[85] "dist_fast" "dist_quiet" "time_fast"
[88] "time_quiet" "cirquity" "distq_f"
[91] "avslope" "co2_saving" "busyness"
[94] "avslope_q" "clc"

from pct-scripts.

usr110 avatar usr110 commented on August 29, 2024

Generated data for Cambridgeshire (by running load.Rmd) which fixed the issue.

cambridge-dataset

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on August 29, 2024

Thanks for such a clear issue report Ali. Must be that it didn't run in the national build for some reason. Will look to fix this.

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on August 29, 2024

@usr110 please can you test that this has worked and re-open if it has not. Pushed onto the main server. Robin

from pct-scripts.

usr110 avatar usr110 commented on August 29, 2024

@Robinlovelace Working fine. Great work!

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on August 29, 2024

Thanks for the report and the feedback @usr110

from pct-scripts.

usr110 avatar usr110 commented on August 29, 2024

It seems both

length
rqincr

still have some issues, as it's showing very weird values.

cambridge-distance

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on August 29, 2024

Thanks @usr110, please could you see if these exist in any other regions? I'll look into it and fix.

from pct-scripts.

usr110 avatar usr110 commented on August 29, 2024

I have just noticed this issue in cornwall and isles of scilly as well. See below:

cornwall

to further investigate the matter, I have looked into both rf.Rds and rq.Rds and found no abnormal behavirours:

summary(rq@data$length)
Min. 1st Qu. Median Mean 3rd Qu. Max.
0.696 6.904 12.710 13.040 18.580 34.520

summary(rf@data$length)
Min. 1st Qu. Median Mean 3rd Qu. Max. NA's
0.696 6.475 11.560 11.890 16.800 28.130 2

so the issue must be when the region-specific data is be being generated.

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on August 29, 2024

Thanks for investigating. Those summary datasets are for the regions in which incorrect data is being shown, right?

from pct-scripts.

usr110 avatar usr110 commented on August 29, 2024

yes, robin. Here's summary of Cambridgeshire's rq data:

summary(rq@data$length)
Min. 1st Qu. Median Mean 3rd Qu. Max.
1.062 20.330 9508.000 9828.000 16960.000 29300.000

from pct-scripts.

Robinlovelace avatar Robinlovelace commented on August 29, 2024

OK great - that will go into the automated data checking script also. Will fix asap.

from pct-scripts.

nikolai-b avatar nikolai-b commented on August 29, 2024

npct/pct-shiny#237

from pct-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.