Giter VIP home page Giter VIP logo

Comments (9)

nikolai-b avatar nikolai-b commented on July 25, 2024

Made some progress on this in dbd2810 , is this what you were after?

from pct-shiny.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

Code looks good but it's not working - think my changes may have broken it. Sorry! Let me know when this up-and-running!

from pct-shiny.

nikolai-b avatar nikolai-b commented on July 25, 2024

Sure, I think it was when you reverted the colour ramp changes that it re-introduced some old code, easily done. I'm not totally sure I've implemented the quartiles how you wanted but now it works can you have a look and close this if it is?

from pct-shiny.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

Looks good.

from pct-shiny.

usr110 avatar usr110 commented on July 25, 2024

@nikolai-b
Thanks for the changes in the legend. It looks really nice.
One thing I've noticed, however, that the y-axis doesn't correspond to the underlying values for the selected zone attribute (the range doesn't correspond to the range of the y-axis). Is this something intentionally introduced?

from pct-shiny.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

@usr110 I don't think this is intended. Please try to fix if you can...

Look forward to catching up!

Robin

from pct-shiny.

usr110 avatar usr110 commented on July 25, 2024

@Robinlovelace I have fixed the errors, I believe - also the dependency with the inputs, for the legend. Could you please update the code on the server? I will then test it out.

from pct-shiny.

Robinlovelace avatar Robinlovelace commented on July 25, 2024

I think it is updated - please test:
http://geo8.webarch.net/pct-shiny/master/
Fantastic work Ali, many thanks.

from pct-shiny.

nikolai-b avatar nikolai-b commented on July 25, 2024

re #15 (comment), sorry that was my mistake. I didn't realize that using isolate in render plot would mean the value never got updated (maybe because as render plot itself is only called once but it is re-evaluated constantly - the Shiny way). Closing now as this seems done.

from pct-shiny.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.