Giter VIP home page Giter VIP logo

Comments (2)

isaacs avatar isaacs commented on August 16, 2024 1

@ruyadorno Here's what I was thinking about at the end of our pairing session just now:

  • this.buildIdealTree(options)
  • for node in this.idealTree.inventory.filter(n => n.extraneous), set node.parent = null
  • Call this.reify() (skips the this.buildIdealTree step, because we already have an idealTree!)

Because here's the thing: if you do npm prune --production, then you should still have dev deps in your package-lock.json file, just not in your node_modules folder. The package-lock.json file is generated by saving the ideal tree to disk, so if we mutate that to remove dev/optional/etc, then it's a problem.

And the reify() logic will already remove dev deps if you do --omit=dev, but keep them in the package-lock.json file.

Also, let's get rid of the list of names feature, since that isn't even supported in npm v6 anyway, and no one seems to mind its absence for the last few years.

from arborist.

isaacs avatar isaacs commented on August 16, 2024

Fixed by #95

from arborist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.