Comments (2)
@ruyadorno Here's what I was thinking about at the end of our pairing session just now:
this.buildIdealTree(options)
- for
node
inthis.idealTree.inventory.filter(n => n.extraneous)
, setnode.parent = null
- Call
this.reify()
(skips thethis.buildIdealTree
step, because we already have an idealTree!)
Because here's the thing: if you do npm prune --production
, then you should still have dev deps in your package-lock.json
file, just not in your node_modules
folder. The package-lock.json
file is generated by saving the ideal tree to disk, so if we mutate that to remove dev/optional/etc, then it's a problem.
And the reify()
logic will already remove dev deps if you do --omit=dev
, but keep them in the package-lock.json
file.
Also, let's get rid of the list of names feature, since that isn't even supported in npm v6 anyway, and no one seems to mind its absence for the last few years.
from arborist.
Fixed by #95
from arborist.
Related Issues (20)
- [BUG] peerOptionals can cause ERESOLVE in peerSet, but aren't included in tree HOT 1
- [BUG] case where ERESOLVE persists when `--force` is used
- [BUG] should not write package.json file if nothing is being changed
- [BUG] another peerOptional ERESOLVE case HOT 1
- [BUG] loadVirtual errors do not get forwarded to the promise correctly HOT 1
- [BUG] dont use package.json underscore-prefixed values HOT 1
- [QUESTION] How to access information about the package what was added/installed HOT 1
- [BUG] Cannot read property 'version' of undefined HOT 1
- [BUG] npm install recursively changes the owner of all files in my project, crashing mysql in docker HOT 1
- [BUG] (CLI-related) npm install ignores explicit prefix HOT 1
- [QUESTION] Isn't this deduplication happening too late in audit? HOT 2
- [BUG] Diff skips deps of non-global link root HOT 1
- [BUG] arborist does not create bin links for packages with `directories.bin`. HOT 4
- [BUG] TypeError: Cannot read property 'name' of undefined HOT 2
- [BUG] Issue of new version 2.7.1 HOT 1
- [BUG] The name property changes depending on project folder name in package-lock.json HOT 4
- [QUESTION] How is the install algorithm supposed to work ? HOT 1
- [BUG] Error when installing packages from local folder: "TypeError: Invalid comparator: file:../some-local/path"
- infinite loop in conflicting transitive peer dependencies HOT 1
- [BUG] npm update not scoped to workspace when no package targeted HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arborist.