Comments (12)
mgansler
commented on June 24, 2024
1
with 19.0.5:
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "eslint"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "eslint"
info Reasons this module exists
- Specified in "devDependencies"
- Hoisted from "@nx#eslint#eslint"
info Disk size without dependencies: "5.5MB"
info Disk size with unique dependencies: "15.11MB"
info Disk size with transitive dependencies: "18.44MB"
info Number of shared dependencies: 80
With 19.0.6:
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "eslint"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "eslint"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "5.38MB"
info Disk size with unique dependencies: "14.99MB"
info Disk size with transitive dependencies: "18.29MB"
info Number of shared dependencies: 82
=> Found "@nx/eslint#[email protected]"
info This module exists because "@nx#eslint" depends on it.
info Disk size without dependencies: "3.8MB"
info Disk size with unique dependencies: "11.71MB"
info Disk size with transitive dependencies: "15.73MB"
info Number of shared dependencies: 80
And with eslint removed from my package.json (and Nx 19.0.6):
y why eslint
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "eslint"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
- "@nx#eslint" depends on it
- Hoisted from "@nx#eslint#eslint"
info Disk size without dependencies: "5.34MB"
info Disk size with unique dependencies: "14.5MB"
info Disk size with transitive dependencies: "18.33MB"
info Number of shared dependencies: 71
Same error though, still context.getScope is not a function
from nx.
mgansler
commented on June 24, 2024
1
When I force eslint to 8.57.0, linting works:
"resolutions": {
"eslint": "8.57.0"
}
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "eslint"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "eslint"
info Reasons this module exists
- Specified in "devDependencies"
- Hoisted from "@nx#eslint#eslint"
info Disk size without dependencies: "5.5MB"
info Disk size with unique dependencies: "15.11MB"
info Disk size with transitive dependencies: "18.44MB"
info Number of shared dependencies: 80
Can someone with npm try this with overrides instead of resolutions?
from nx.
JamesHenry
commented on June 24, 2024
1
FYI we confirmed this is only an issue with yarn. The other package managers behave how we expected and do not force the eslint v9 dependency upon you. We are still discussing the ultimate resolution to this.
from nx.
mgansler
commented on June 24, 2024
I have noticed a very similar behaviour:
Linting "components"...
NX context.getScope is not a function
Occurred while linting /builds/mgansler/plusone/libs/components/cypress/support/commands.ts:14
Rule: "import/no-amd"
Worked fine with 19.0.5 but is broken with 19.0.6 and no other changes.
The version of @typescript-eslint/* seems to make no difference for me, same result with 7.3.0 and 7.10.0
from nx.
SteveW94
commented on June 24, 2024
I experienced the same.
Due to this the Update PR is currently on hold
from nx.
Tijawk
commented on June 24, 2024
I have huge performance issue with lerna since I have updated nx from 19.0.5 to 19.0.6. I use @typescript-eslint/*@7.10.0 too,
I think it's the same probleme. I have rollback to 19.0.5.
from nx.
FrozenPandaz
commented on June 24, 2024
I have huge performance issue with lerna since I have updated nx from 19.0.5 to 19.0.6. I use @typescript-eslint/*@7.10.0 too,
I think it's the same probleme. I have rollback to 19.0.5.
Mm.. this isn't much details but I think this might be a separate issue unrelated to this one.
NX context.getScope is not a function
Thank you for reporting it. We'll look into it.
from nx.
JamesHenry
commented on June 24, 2024
@TomTomB @mgansler @SteveW94 Maybe you are now pulling in eslint v9?
Please try running this command or similar and see what version of eslint is getting pulled in:
npm ls eslint
from nx.
JamesHenry
commented on June 24, 2024
@Tijawk Please open a fresh issue for your case with maximum information/steps to reproduce
from nx.
TomTomB
commented on June 24, 2024
@JamesHenry Both eslint versions (8.57.x, and 9.x) result in the same error.
from nx.
SteveW94
commented on June 24, 2024
@JamesHenry
This is before the installation of 19.0.6
As you can see no eslint 9
Just after installation of 19.0.6
You can see, @nx/[email protected] is the culprit, as it references eslint 9!
In my package .json there is:
"eslint": "8.57.0" pinned. So no Semver Tag or anything.
So I would say, this way ESLint "sneaks" in there should not be intended!
from nx.
SteveW94
commented on June 24, 2024
👍🏼
from nx.
Related Issues (20)
- Updating nx from 19.0.2 to 19.1.1 breaks Storybook HOT 1
- Receiving error Cannot read properties of undefined (reading 'resolve') after NX 16.10.0 upgrade from 16.9.1
- Inferred tasks collide with scripts in package.json HOT 2
- Jest TypeScript Resolver Incorrectly Resolves TSConfig
- [BROKEN CACHE] Inconsistency in parsed-lock-file.json between Linux and Mac when using Yarn v1
- 'ProjectGraphError' from `@nx/vite` breaking all targets and built-in commands HOT 2
- dependsOn projects exclusion does not work HOT 1
- Default plugin tests hangs because of handles in NX 19 HOT 1
- package name is not inferred from scope without project.json file HOT 2
- uv_os_get_passwd returned ENOENT in docker HOT 5
- Unable to remove zone.js from Angular library polyfills HOT 1
- NX Unsupported payload sent to daemon server: {"type":"GLOB","globs":["**/{vite,vitest}.config.{js,ts,mjs,mts,cjs,cts}"]} HOT 4
- Cache miss when changing excluded file HOT 1
- @nx/esbuild:esbuild `declarations: true` does not include tsconfig path mappings for buildable libraries
- @nx/esbuild:esbuild with thirdParty: false fails filtering pnpm lock-file correctly in 19.2.x by not removing overrides HOT 1
- Unused Exports Included in Bundle Despite Configuration HOT 1
- [Nest] Nest generator directory wrong behavior
- Using angular libraryGenerator with prettier v3 results in error
- storybook "No Eslint configuration" issue after upgrading to v19 HOT 1
- `@angular/material` not getting updated to v18 from v17.x but `@angular/cdk` is getting updated when running `npx nx migrate latest` and `npx nx migrate --run-migrations` HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nx.