Crashes app on android. about nativescript-pulltorefresh HOT 9 CLOSED

This is crazy, but this bug has resurfaced. It happens for me in 3.4.1.

from nativescript-pulltorefresh.

@bradmartin do you agree that this can and should be fixed in the pulltorefresh plugin?

from nativescript-pulltorefresh.

Possibly, I'm just not sure right now what the plugin would be doing that would cause it 🤔 if we know what the cause is then fixing here is great. I'm just not sure without more debugging on the issue and limited on time right now :(

from nativescript-pulltorefresh.

@PeterStaev helped with updating the plugin and he might be a little 'fresh' on the specifics of the plugin having recently worked on it. Peter, do you have any idea what would cause the PullToRefresh layout to cause this issue?

from nativescript-pulltorefresh.

My guess is this might relate to https://github.com/bradmartin/nativescript-pulltorefresh/blob/master/pulltorefresh-common.ts#L14, where we remember the initial value and then change it back. This was done as far as i remember because when you set the color property of the widget it also changed the color of all the content inside it.

from nativescript-pulltorefresh.

I've just did a quick test, and good news is this problem is not present in 2.0.0 version of the plugin and the core 3.0 modules. So my guess is it was a mix of some problem with the 2.5 core modules and how the plugin is implemented.

@davecoffin I would suggest using the workaround that @bradmartin suggested - to define a color property for the label, and then when you upgrade your project to {N} 3.0 to remove that color.

from nativescript-pulltorefresh.

@davecoffin is this better as Peter suggested with 3+? I'm about to implement it in an app so I'll report back if any issue related to this.

from nativescript-pulltorefresh.

@bradmartin I'm not ignoring you, I went to test this yesterday morning which sent me on a wild goose chase fixing android build bugs that I still havent resolved.

from nativescript-pulltorefresh.

@davecoffin @bradmartin
I also get this error using NS 5.2 and the latest version of this plugin.

Surprisingly the error does not occur if I add a color to the Label.

<Label text="Test"/> --> crash
<Label text="Test" color="black"/> --> no crash

from nativescript-pulltorefresh.