Giter VIP home page Giter VIP logo

Comments (10)

willwhitney avatar willwhitney commented on June 22, 2024

This is a problem with the Atom API for markers. I've opened an issue at atom/atom#6857 — I need them to fix it before I can address this, unfortunately.

from hydrogen.

willwhitney avatar willwhitney commented on June 22, 2024

Or rather, I could fix it for us, but at risk of breaking other packages (as I mention on that thread). I think it's unlikely that any packages depend on the exact z-index of the tab bar, so if they don't get a fix done soon I'll just do that.

from hydrogen.

willwhitney avatar willwhitney commented on June 22, 2024

Went ahead and did this. Shipped in v0.4.0!

from hydrogen.

X-G avatar X-G commented on June 22, 2024

Thanks Will.

from hydrogen.

n-riesco avatar n-riesco commented on June 22, 2024

This issue is still present in v0.7.1

from hydrogen.

n-riesco avatar n-riesco commented on June 22, 2024

This comment shows the issue clearly.

from hydrogen.

rgbkrk avatar rgbkrk commented on June 22, 2024

Block decorations should be the way forward. http://blog.atom.io/2016/02/03/introducing-block-decorations.html

from hydrogen.

n-riesco avatar n-riesco commented on June 22, 2024

@rgbkrk I've tried the following with Atom 1.7.0-dev-7040035 and it doesn't seem to work:

$ git diff
diff --git a/lib/main.coffee b/lib/main.coffee
index 7afdb18..10b2ef0 100644
--- a/lib/main.coffee
+++ b/lib/main.coffee
@@ -159,9 +159,9 @@ module.exports = Hydrogen =
         view.statusContainer.setAttribute('style', "height: #{lineHeight}px")

         @editor.decorateMarker marker,
-            type: 'overlay'
+            type: 'block'
             item: element
-            position: 'tail'
+            position: 'after'

         @markerBubbleMap[marker.id] = view
         marker.onDidChange (event) =>
diff --git a/styles/hydrogen.less b/styles/hydrogen.less
index 5ba24fa..cd98ed4 100644
--- a/styles/hydrogen.less
+++ b/styles/hydrogen.less
@@ -5,20 +5,6 @@
 @import "ui-variables";
 @import "syntax-variables";

-// this is a hack to deal with a failing of the markers API
-// https://github.com/atom/atom/issues/6857
-.tab-bar {
-    z-index: 5;
-}
-
-.bottom{
-    z-index: 4;
-}
-
-atom-overlay.autocomplete-plus {
-  z-index: 6;
-}
-
 .hydrogen.output-bubble {
     @light-bubble-background: fadein(lighten(@syntax-background-color, 40%), 100%);
     @dark-bubble-background: fadein(lighten(@syntax-background-color, 10%), 100%);

untitled

from hydrogen.

lgeiger avatar lgeiger commented on June 22, 2024

@n-riesco if you remove this line the result should be displayed. But of course the styling will be totally messed up.

from hydrogen.

n-riesco avatar n-riesco commented on June 22, 2024

@lgeiger Here's how it looks like after removing position: absolute:

untitled

from hydrogen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.