Giter VIP home page Giter VIP logo

Comments (6)

fabiensanglard avatar fabiensanglard commented on August 15, 2024

Submitted pull request: #21

from pcdoom-v2.

AXDOOMER avatar AXDOOMER commented on August 15, 2024

I would say that this is normal because PCDoom-v2 emulates the Ultimate Doom version of the Doom v1.9 executable, which has this bug because this version wasn't meant to be run with the shareware or the registered IWAD, only the Ultimate Doom. If you try the IWAD from the registered version, you'd get the same crash and your fix doesn't resolve it.

Also, please check if this fix still makes it possible to select the fourth episode. By looking at the fix, I see that it won't be drawn on the screen but you may still be able to move the skull cursor over its position where it's supposed to be in the menu.

from pcdoom-v2.

AXDOOMER avatar AXDOOMER commented on August 15, 2024

Hi Fabien,

One way to fix it would be to add a check at the end of M_Init.

// Remove the fourth episode if the "m_epi4" lump is not found
if (W_CheckNumForName("m_epi4")<0)
    EpiDef.numitems--;

I haven't tested this code, but something with this logic would also work with the registered version of Doom, assuming that numitems is always equals to the size of the array which contains the four episodes.

from pcdoom-v2.

nukeykt avatar nukeykt commented on August 15, 2024

I think i should add earlier versions emulation using '#ifdef's. Emulation of versions down to 1.666 should be easy.

from pcdoom-v2.

AXDOOMER avatar AXDOOMER commented on August 15, 2024

I think i should add earlier versions emulation using '#ifdef's.

I think that's a great idea.

from pcdoom-v2.

nukeykt avatar nukeykt commented on August 15, 2024

Fixed in 886a838

from pcdoom-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.