Giter VIP home page Giter VIP logo

Comments (1)

sukima avatar sukima commented on June 26, 2024

I think registerDestructor needs this as a first parameter. I believe it needs this to have it participate in the component tear down right?

  @action setupWindowListener() {
    /* setup */
    let cleanup = new AbortController();
    let { signal } = cleanup;
    window.addEventListener('beforeunload', this.handleUnload, { signal })

    /* tear down */
    registerDestructor(this, () => cleanup.abort);
  }

Also in this simple example you can get away with an extra object creation:

  @action setupWindowListener() {
    /* setup */
    let cleanup = new AbortController();
    window.addEventListener('beforeunload', this.handleUnload, cleanup)

    /* tear down */
    registerDestructor(this, () => cleanup.abort);
  }

from limber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.