StringAssert.IsNullOrEmpty overloads about nunit HOT 6 OPEN

The StringAsserts are part of the legacy/classic assertions. Although we don't expect to do anything more with these, what you suggest can be added, as they seem to be just additions, causing no breaking changes or changes to existing assertions.

All the StringAssert methods are implemented in terms of the constraint model, like:

 public static void StartsWith(string expected, string actual, string message, params object?[]? args)
 {
      Assert.That(actual, Does.StartWith(expected), () => ConvertMessageWithArgs(message, args));
 }

And this is the way your suggestions should be implemented too.

Suggestion 1 and 3 can easily be added, as they are just simple translations like:

Assert.That(somestring,Is.Not.Null.And.Not.Empty);

PS: Have you considered using the constraint syntax instead?

No 2 and 4 include whitespace, and we currently don't have a constraint for whitespace. (We could probably have that, as it is frequently used in code. ). A solution would be to use the Regex constraint.

We do have an open issue on this, see #3918. Perhaps due time to fix this @stevenaw @manfred-brands ?

The team will probably not do this (except for creating a whitespace constraint or modifier at some time), but we are very open to receive a Pull Request for StringAsserts. That PR also has to contain unit tests for the asserts. It should be easy to add, and placed along with the other string assert tests.

Since this adds functionality it has to go along with the same assertions being documented in the docs repo, under the section for StringAssert.

from nunit.

@OsirisTerje I wouldn't mind adding a Whitespace constraint and also implement #3918.
I currently work around that issue using Assert.That(NoSpaces(json), Is.EqualTo(NoSpaces(expectedJson))

from nunit.

@manfred-brands Awesome if you implement that!

How should the syntax be ? There are different alternatives, and we should try to be as close as we can to the constraint design.

There might be more than a few scenarios.

Some random thoughts:

Is.EqualTo(sometring).IgnoreWhiteSpace() // Ignores all whitespace in string

or

Is.EqualTo(sometring).WhiteSpace.IgnoreAll // Looks a bit weird to me, but doesnt need multiple variations of WhiteSpace, only modifiers.

so could also be:

Is.EqualTo(sometring).WhiteSpace(IgnoreAll)

Is.EqualTo(somestring).TrimWhiteSpace() // Ignore leading and ending whitespace

or

Is.EqualTo(somestring).WhiteSpace().Trim() or as above include as parameter

Assert.That(sometring,Is.WhiteSpace() // string consist only of whitespace
Assert.That(somestring,Has.WhiteSpace() // string has some whitespace in it

and it should be possible to write
Assert.That(somestring,Is.Not.Null.And.Not.WhiteSpace

from nunit.

@OsirisTerje See #4664

from nunit.

Awesome! Looks very good!

from nunit.

Thanks, I will try and work on this when I have free time, hopefully over the next few months.

from nunit.