Giter VIP home page Giter VIP logo

Comments (5)

baxtersa avatar baxtersa commented on September 14, 2024

The solution would be to enclose the output from desugarSwitch in a labelled block and turn the break;s into labelled breaks.

This is handled in a prior transform, desugarLabels. We should at least figure out a better way of documenting dependencies among babel visitors, and probably look into consolidating this logic into a single pass so that it works in isolation. Haven't thought about or looked at how much they could be merged yet though.

from stopify.

arjunguha avatar arjunguha commented on September 14, 2024

This is all good. Thanks. No need to change anything.

from stopify.

rachitnigam avatar rachitnigam commented on September 14, 2024

@sbaxter if there is a dependency between the two transforms, they should be merged. Two dependent transforms should not be separated unless absolutely necessary.

from stopify.

rachitnigam avatar rachitnigam commented on September 14, 2024

Reopening because of my prior comment.

from stopify.

baxtersa avatar baxtersa commented on September 14, 2024

@rachitnigam , it's not that easy. There are a handful of desugars which involve two-stage plugins right now, it's not just this one. I'm closing this and opening a specific issue to look into consolidating desugars to map one-to-one to visitors.

from stopify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.