Giter VIP home page Giter VIP logo

Comments (7)

TGNThump avatar TGNThump commented on July 19, 2024

It might also be nice to add native support for the other https://webonyx.github.io/graphql-php/security/ features too.

from lighthouse.

olivernybroe avatar olivernybroe commented on July 19, 2024

What about a @queryDepth(maxDepth: 10) directive we can set on each query? :)
And maybe also in conf add a queryDepth so we can set it as global

from lighthouse.

TGNThump avatar TGNThump commented on July 19, 2024

@olivernybroe Sounds good. I'm way more interested in the Query Complexity Analysis than Limiting Query Depth, but yeah, both features are definitely needed.

from lighthouse.

olivernybroe avatar olivernybroe commented on July 19, 2024

@TGNThump Implementing them would be really similiar as they are both just Rules. But I am totally up for having Complexy, QueryDepth and prob. also Introspection disabling.

from lighthouse.

chrissm79 avatar chrissm79 commented on July 19, 2024

@olivernybroe All three of those are definitely items that should be available in Lighthouse... added to v2.x label. First beta of subscriptions is done, I need to add some initial docs for it then I'll cut v2.1 of Lighthouse and I'll get started on new items (such as #101, #99, #98) for v2.2. I'll try to keep this issue updated as these items get added in. Thanks @TGNThump @olivernybroe!!

from lighthouse.

spawnia avatar spawnia commented on July 19, 2024

Does the SecurityDirective resolve this issue or does it need anything else?

from lighthouse.

spawnia avatar spawnia commented on July 19, 2024

Closing this, as SecurityDirective and the ComplexityDirective should cover it. @TGNThump if you are still missing something, let us know.

from lighthouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.