Giter VIP home page Giter VIP logo

Comments (3)

chrissm79 avatar chrissm79 commented on July 19, 2024

@hailwood Love this! Didn't even notice the new forPageAfterId but it sounds like a pretty solid drop in replacement. I also really like the encode/decode functionality you're proposing here... so if someone wanted to base it off a different column (such as a timestamp) they could, we would just need to allow them to override the column name in their connection class.

I'll try to add in this functionality by next week unless you wanted to submit a PR.

Thanks!!

from lighthouse.

chrissm79 avatar chrissm79 commented on July 19, 2024

@hailwood Actually, I don't think forPageAfterId would necessarily work. Primarily because it's not a LengthAwarePaginator so we don't have things like the total count. It also looks like we might run into issues when trying to sort desc or if we have a sort on a different field coming from an argument in the resolver. I'll look into the issues you're experiencing and see if I can find out what's going on, but in the meantime it seems like it would still be beneficial to move from a trait to a Relationship macro.

from lighthouse.

hailwood avatar hailwood commented on July 19, 2024

Fixed via #65

from lighthouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.