Set privateRuntimeConfig for cdn use about sanity HOT 9 OPEN

@JonathanDoelan Could you clarify what you think should be the default behaviour?

from sanity.

@danielroe the privateRuntimeConfig-part. But this maybe conflicts with the mode, where ssr=true and target=server. Because then it would always use the uncached cdn.

So I think it should be mentioned at least in the docs. For the reasons I‘ve described above.

from sanity.

@JonathanDoelan I don't think this is the right approach. I would instead simply create a plugin that - if in server mode - sets the useCdn option to false. Then I think you would achieve your desired behaviour of getting freshest content when statically generated, yet using the CDN on client-side.

from sanity.

@danielroe What do you mean? Making it default is not the right approach or putting it inside privateRuntimeConfig? Creating a plugin is simpler than the privateRuntimeConfig snippet (in the docs)?

from sanity.

@JonathanDoelan I don't think putting it inside privateRuntimeConfig is quite right given what you want to achieve. After all, this will hard code the useCdn: false into your generated pages...

from sanity.

@danielroe oh ok. I’ve spent quite some time to come to this solution. … how would you do it/how should I do it?

from sanity.

I would instead simply create a plugin that - if in server mode - sets the useCdn option to false.

from sanity.

@danielroe Here is my approach like you’ve suggested:

// sanity-no-cache.server.js
// Do not use Sanitys CDN when (pre-)rendering server-side and isStatic
export default ({ $sanity, isStatic }) => {
    if (isStatic) {
        $sanity.config.useCdn = false;
    }
}

But it does not work. It again takes the CDN, so that the prerendered app contains the old data.
How can we solve this?

from sanity.

@JonathanDoelan At the moment you'd need to overwrite $sanity.client completely, but I think your approach (of just setting config) is more intuitive, so I'll refactor.

from sanity.