Giter VIP home page Giter VIP logo

Comments (9)

benjamincanac avatar benjamincanac commented on May 22, 2024 4

@ddahan Thanks for pointing this out! I took inspiration of it: https://ui-5uya9y0gg-nuxtlabs.vercel.app/navigation/tabs

from ui.

goodpixels avatar goodpixels commented on May 22, 2024 1

That's fine @benjamincanac - I personally don't think it's a bad thing at all.

Perhaps the the VerticalNavigation could simply become the new Tabs component?

It should provide two components, <TabNavigation> and <TabPanel>. Users could choose the placement of the tabs as they please, top, right, bottom or left and they would switch between different <TabContent> panels.

Another way to think about it is pretty much as an extension, or an evolution, of the Vertical Navigation. I think the current component has a pretty limited usage, and turning it into something more robust would be a great way forward.

from ui.

benjamincanac avatar benjamincanac commented on May 22, 2024 1

@oritwoen Sure thing, feel free to send a PR! The goal is here is to have something similar to https://ui.shadcn.com/docs/components/tabs based on https://headlessui.com/vue/tabs.

from ui.

TomSmith27 avatar TomSmith27 commented on May 22, 2024

Do you have a particular design we should use to base this on?

from ui.

benjamincanac avatar benjamincanac commented on May 22, 2024

I'm still thinking this through honestly. I know I'd like the tabs component to support either links or slots but for the design I've tried multiple times with pills, but each time I'm reverting the whole thing as it comes out exactly like the VerticalNavigation component with a flex class on it.

from ui.

oritwoen avatar oritwoen commented on May 22, 2024

@benjamincanac have you started with this feature yet? From time to time I create components for client platforms/sites and I could opensource my vision of tabs and draft PR if you didn't manage to start with this component :)

from ui.

ddahan avatar ddahan commented on May 22, 2024

I like the light animation they add on Pines UI when switching tab.

from ui.

goodpixels avatar goodpixels commented on May 22, 2024

Looks great!

from ui.

ddahan avatar ddahan commented on May 22, 2024

@benjamincanac Woow amazing! Keep up the great work!

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.