Giter VIP home page Giter VIP logo

Comments (2)

noook avatar noook commented on July 1, 2024 1

This is a personal preference. Some prefer having the modal in the template so it is easier for the modal to track changes on props, others prefer having it in the script so it doesn't appear in the template.

A lot of usecases exist, and I know that for most of them, I would use a higher order component (a new component that has for root an <UModal />) so that I can reuse UModal props, and extend it with my own props.

I'm not a fan of programmatically opened modals, but I know for sure this is the most convenient way to open one or another modal depending on a condition that could be declared in a function.

Also, note that when opening modals programmatically, your modal component needs to have UModal as the root component because useModal().open() passes the props to UModal.

from ui.

eduardo-faith avatar eduardo-faith commented on July 1, 2024

Thanks @noook for your answer! I accept the idea of passing own props.

Also, note that when opening modals programmatically, your modal component needs to have UModal as the root component because useModal().open() passes the props to UModal.

That's my point: If I'm forced to have a UModal, why not take away the need to write the code? 😉

Anyhow, I will find a workaround or create a relatively empty higher order component!
Thanks for your time and continue the great work 💪

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.