Giter VIP home page Giter VIP logo

Comments (12)

siduck avatar siduck commented on July 18, 2024

and what happens when you have tabufline not lazyloaded?

from ui.

charludo avatar charludo commented on July 18, 2024

I have this in my chadrc:

["NvChad/ui"] = {
  override_options = {
    tabufline = {
      lazyload = false,
      overriden_modules = nil,
    },
  },
},

which, I think, should disable lazy loading? From the documentation it sounds like lazy means the tabufline won't be shown if there's only a single buffer open. But it does show the tabufline for me, just with only one buffer.

Looks like this is related to / a duplicate of NvChad/NvChad#1277. I see there's a couple of related commits, which I guessed fixed the issue (it was indeed working correctly for me until updating NvChad yesterday), but I guess something broke again, either here or in a recent nvim version?

from ui.

siduck avatar siduck commented on July 18, 2024

tabufline shows multiple buffers if multiple files are opened with nvim

vid.mp4

from ui.

charludo avatar charludo commented on July 18, 2024

Yes. This works for me as well. The issue only appears when sourcing a session file:
Demo

from ui.

siduck avatar siduck commented on July 18, 2024

@lll9p can you look into this? I got no clue

from ui.

jtuz avatar jtuz commented on July 18, 2024

@charludo, this is not a NvChad related issue, this is with nvim, and no matter what config are you using, I had the same problem in the past, but this solve my problems: https://github.com/natecraddock/sessions.nvim

from ui.

siduck avatar siduck commented on July 18, 2024

@jtuz probably, but if it doesnt happen with other bufferline plugins then we will have to fix our tabufline too

from ui.

charludo avatar charludo commented on July 18, 2024

@charludo, this is not a NvChad related issue, this is with nvim, and no matter what config are you using, I had the same problem in the past, but this solve my problems: https://github.com/natecraddock/sessions.nvim

Are you sure? I have done some further testing, and it turns out the buffers are loaded (I can cycle them with e.g. :bprevious, and make all of them appear with :bufdo e). It seems they simply aren't being displayed until some event affects them (cycling, reloading, closing the currently displayed one).

from ui.

siduck avatar siduck commented on July 18, 2024

@charludo do the buffers show with bufferline.nvim plugin? ( disable tabufline temporarily for testing )

from ui.

charludo avatar charludo commented on July 18, 2024

@charludo do the buffers show with bufferline.nvim plugin? ( disable tabufline temporarily for testing )

Yes, they do!

Seeing as everything worked perfectly up until a couple of days ago, I have a hunch this might have been broken in #33?

from ui.

siduck avatar siduck commented on July 18, 2024

@lll9p watchout

from ui.

lll9p avatar lll9p commented on July 18, 2024

@lll9p watchout

Sorry for not replying in time. To identify a buf's validation is complicated and it is difficult to test all situations. I think we need more test on different situations.

For this Issue, I have proposed a PR, please review, thanks!

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.