Giter VIP home page Giter VIP logo

Comments (8)

fversaci avatar fversaci commented on May 30, 2024 1

Thanks @JanuszL and @klecki !

Then, if it's okay to ship numpy.h, I will prepare a PR to fix that and also to add bool pinned to ReadTensor.

from dali.

JanuszL avatar JanuszL commented on May 30, 2024 1

Hi @fversaci,

Please add REBUILD_BUILDERS=YES to the build.sh invocation to rebuild cmake with https support (NVIDIA/DALI_deps#99) needed to pull nvImageCodec.

from dali.

fversaci avatar fversaci commented on May 30, 2024 1

Hi, I've created the PR. Please have a look and let me know if it looks okay to you or if any changes are needed.

from dali.

JanuszL avatar JanuszL commented on May 30, 2024 1

Just merged. It should be available in the next nightly build.

from dali.

JanuszL avatar JanuszL commented on May 30, 2024

Hi @fversaci,

Thank you for reaching out.

  1. The numpy.h header file does not seem to be available to the user (it's not being installed here), so we included it in our code as dali_numpy.h. Would it be possible to make it available for the users as well?

@szkarpinski, @klecki do you remember what was the reason for not shipping this file?

  1. The original ReadTensor function always creates tensors in pinned memory. We want to be able to use it also in normal memory, so we extended ReadTensor to NewReadTensor, which also accepts a bool pinned argument. If that doesn't break anything you're using, it might be useful to have it directly in the original ReadTensor function.

It could be just an oversight. As I see this function is used only in tests. Feel free to post a PR that would fix this.

  1. We use NewReadTensor in the decoder in a serial way. Is this function thread-safe, and could we use it in parallel as well?

As far as I see the functions used are stateless and the only side effect I see is the change of the InputStream state. So if you want to share the same InputStream between multiple concurrent threads it won't work.

from dali.

klecki avatar klecki commented on May 30, 2024

@JanuszL it looks like an oversight for me with regards to the numpy.h, but @azrael417 or @mzient may know more about it.

from dali.

fversaci avatar fversaci commented on May 30, 2024

Hi,

I'm trying to compile DALI (using docker builder) to prepare the PR, but i get an error.

Am doing something wrong?

I'm launching this

git clone --recursive https://github.com/NVIDIA/DALI
cd DALI/docker
CUDA_VERSION=12.2 CREATE_RUNNER=yes ./build.sh

which causes this

CMake Error at nvimgcodec_headers-subbuild/nvimgcodec_headers-populate-prefix/src/nvimgcodec_headers-populate-stamp/download-nvimgcodec_headers-populate.cmake:1
59 (message):
  Each download failed!

    error: downloading 'https://developer.download.nvidia.com/compute/nvimgcodec/redist/nvimgcodec/linux-x86_64/nvimgcodec-linux-x86_64-0.2.0.6-archive.tar.xz'
failed
         status_code: 1
         status_string: "Unsupported protocol"
         log:
         --- LOG BEGIN ---
         Protocol "https" not supported or disabled in libcurl

  Closing connection -1



         --- LOG END ---
         error: downloading 'https://developer.download.nvidia.com/compute/nvimgcodec/redist/nvimgcodec/linux-x86_64/nvimgcodec-linux-x86_64-0.2.0.6-archive.tar
.xz' failed
         status_code: 1
         status_string: "Unsupported protocol"
         log:
         --- LOG BEGIN ---
         Protocol "https" not supported or disabled in libcurl

  Closing connection -1

[...]

gmake[2]: *** [nvimgcodec_headers-populate-prefix/src/nvimgcodec_headers-populate-stamp/nvimgcodec_headers-populate-download] Error 1
gmake[1]: *** [CMakeFiles/nvimgcodec_headers-populate.dir/all] Error 2
gmake: *** [all] Error 2

CMake Error at /usr/local/share/cmake-3.18/Modules/FetchContent.cmake:987 (message):
  Build step for nvimgcodec_headers failed: 2
Call Stack (most recent call first):
  /usr/local/share/cmake-3.18/Modules/FetchContent.cmake:1082:EVAL:2 (__FetchContent_directPopulate)
  /usr/local/share/cmake-3.18/Modules/FetchContent.cmake:1082 (cmake_language)
  cmake/Dependencies.common.cmake:293 (FetchContent_Populate)
  cmake/Dependencies.cmake:108 (include)
  CMakeLists.txt:293 (include)


-- Configuring incomplete, errors occurred!
See also "/opt/dali/build-docker-Release-122_x86_64/CMakeFiles/CMakeOutput.log".
See also "/opt/dali/build-docker-Release-122_x86_64/CMakeFiles/CMakeError.log".

from dali.

fversaci avatar fversaci commented on May 30, 2024

Perfect, thanks!

from dali.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.