Giter VIP home page Giter VIP logo

Comments (3)

kwen2501 avatar kwen2501 commented on August 20, 2024

Hi, have you tried a clean build from a clean clone of nccl-tests?

Also, are you building on some specific platforms like ARM? I was wondering if the #pragma weak feature could have been deprecated in some newer compiler toolchains. Ref: https://developer.arm.com/documentation/dui0491/i/Compiler-specific-Features/-pragma-weak-symbol---pragma-weak-symbol1---symbol2

Could you please see if the following change fixes the issue? Thanks!

--- a/src/all_reduce.cu
+++ b/src/all_reduce.cu
@@ -106,9 +106,7 @@ testResult_t AllReduceRunTest(struct threadArgs* args, int root, ncclDataType_t
   return testSuccess;
 }

-struct testEngine allReduceEngine = {
+struct testEngine ncclTestEngine = {
   AllReduceGetBuffSize,
   AllReduceRunTest
 };
-
-#pragma weak ncclTestEngine=allReduceEngine

from nccl-tests.

AmericanEnglish avatar AmericanEnglish commented on August 20, 2024

@kwen2501 This did indeed fix the issue for compiling all_reduce.cu. I am not compiling for arm. I am compiling for an Intel Skylake Xeon Gold and an Intel Ivybridge Xeon. I then run into issues compiling the other cu files due to the same problems. I assume that make this change everywhere will most likely fix the problem.

from nccl-tests.

AmericanEnglish avatar AmericanEnglish commented on August 20, 2024

Applying your suggested change too all cu files now allows for everything to compile.

[barajasc@gpunode102 nccl-tests]$ make -j 16
make -C src build
make[1]: Entering directory `/users/barajasc/tests/nccl/nccl-tests/src'
Compiling  all_reduce.cu                       > ../build/all_reduce.o
Compiling  common.cu                           > ../build/common.o
Compiling  all_gather.cu                       > ../build/all_gather.o
Compiling  broadcast.cu                        > ../build/broadcast.o
Compiling  reduce_scatter.cu                   > ../build/reduce_scatter.o
Compiling  reduce.cu                           > ../build/reduce.o
Compiling  alltoall.cu                         > ../build/alltoall.o
Linking  ../build/all_reduce.o               > ../build/all_reduce_perf
Linking  ../build/all_gather.o               > ../build/all_gather_perf
Linking  ../build/broadcast.o                > ../build/broadcast_perf
Linking  ../build/reduce_scatter.o           > ../build/reduce_scatter_perf
Linking  ../build/reduce.o                   > ../build/reduce_perf
Linking  ../build/alltoall.o                 > ../build/alltoall_perf
make[1]: Leaving directory `/users/barajasc/tests/nccl/nccl-tests/src'

from nccl-tests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.