Continuing the discussion from <a class="issue-link js-issue-link" data-error-text="Fa

Dynamically resolve it and friends <p dir="auto

nio and busted? about neotest HOT 2 OPEN

HiPhish commented on July 19, 2024

nio and busted?

from neotest.

Comments (2)

HiPhish commented on July 19, 2024

Injecting `it`

Here is a hack that works: we explicitly inject it into nio.tests.it:

nio.tests.it = function(it, name, async_func)
  it(name, with_timeout(async_func, tonumber(vim.env.PLENARY_TEST_TIMEOUT)))
end

Now we can write the test:

	nio.tests.it(it, 'Discovers nothing in an empty file', function()
		vim.fn.writefile({''}, tempfile, 's')
		local result = adapter.discover_positions(tempfile)
	end)

It is kind of pointless to have separate it, before_each and after_each functions inside nio.tests if we have to pass the globals explicitly anyway. So we can add a metatable to nio.tests that lets us call the module and pass the global busted function:

local mt = {
	__call = function(_table, hook, name, async_func)
		hook(name, with_timeout(async_func, tonumber(vim.env.PLENARY_TEST_TIMEOUT)))
	end
}

setmetatable(nio.tests, mt)

With this the module remains backwards compatible and the test is less noisy:

	nio.tests(it, 'Discovers nothing in an empty file', function()
		vim.fn.writefile({''}, tempfile, 's')
		local result = adapter.discover_positions(tempfile)
	end)

What do you think? Is this an acceptable solution?

from neotest.

HiPhish commented on July 19, 2024

Dynamically resolve `it` and friends

A variant of the previous solution which preserves the existing API without making the module callable. Here we use the __index metamethod to automatically resolve it, before_each and after_each when they are requested.

local mt = {
	__index = function(_table, key)
		local env = getfenv(2)
		local hook = env[key]
		return function(name, async_func)
			hook(name, with_timeout(async_func, tonumber(vim.env.PLENARY_TEST_TIMEOUT)))
		end
	end
}

setmetatable(nio.tests, mt)

Now the test can be written as usual:

	nio.tests.it('Discovers nothing in an empty file', function()
		vim.fn.writefile({''}, tempfile, 's')
		local result = adapter.discover_positions(tempfile)
	end)