`free(): invalid pointer` crash on `php_only` parser about nvim-treesitter HOT 16 CLOSED

You can check the code to see exactly how we build it. This needs to be fixed upstream; if you rely on the parser, just lock your nvim-treesitter version until then.

from nvim-treesitter.

I think they are functionally equivalent. You can test tree-sitter build -o php_only.so to see how that behaves. (Nvim-treesitter will switch to that in 1.0 anyway.)

from nvim-treesitter.

@clason reported upstream.

I don't know if it will help, I found that error occurs on injections (and when compiled with -Os of course).

reproducer:

<?php

$query = <<<SQL
select * from users;
SQL;

from nvim-treesitter.

@przepompownia Renaming php_only.so forced the plugin to download it again, but the error was still there. Then I updated the plugin via lazy (:Lazy then U), and it seems to be working fine now! Thanks.

from nvim-treesitter.

Then you should report that with that parser; there's nothing we can do about it here.

from nvim-treesitter.

Not completely. Maybe it would be better to revert 4e21361 while the parser crashes on tree-sitter/tree-sitter-php@58054be.

On the tree-sitter-php side I still haven't investigated how to get the same parser binary as created with nvim-treesitter. It differs from the build by make -C php_only there. That's (at least) why I can't report a bug there for now.

from nvim-treesitter.

Yet one note here (on Linux with gcc).

1. nvim-treesitter builds the parser with

cc -o parser.so -I./src src/parser.c src/scanner.c -Os -shared -fPIC`

2. make's output on the project shows another way of building the binary that doesn't crash:

    cc -Isrc -std=c11 -fPIC   -c -o src/parser.o src/parser.c
    cc -Isrc -std=c11 -fPIC   -c -o src/scanner.o src/scanner.c
    ar rv libtree-sitter-php_only.a src/parser.o src/scanner.o
    ar: creating libtree-sitter-php_only.a
    a - src/parser.o
    a - src/scanner.o
    cc  -shared -Wl,-soname,libtree-sitter-php_only.so.0 src/parser.o src/scanner.o  -o libtree-sitter-php_only.so

3. The CLI seems to build its own parser binary (stored in ~/.cache folder) in an unknown way, which makes reproduction difficult (tree-sitter/tree-sitter#3336).

Should we assume that the way used by nvim-treesitter is always correct?

from nvim-treesitter.

I think they are functionally equivalent.

For some reason, 1. produces crashing binary unlike 2.

tree-sitter build -o php_only.so

I'm confused: currently I have CLI written in Rust, from Debian package (0.20.8-5). It does not have build subcommand. I tried tree-sitter generate --build. It resulted with ~/.cache/tree-sitter/lib/php_only.so but without details about compiling.

from nvim-treesitter.

Yeah, that's too old. Current is 0.22.5 (soon to be 6), with massive changes. That's what we target, exclusively.

from nvim-treesitter.

Indeed, in the new version build exists and builds the correct binary.

from nvim-treesitter.

I faced simlar issue. when trying to open some php files I get munmap_chunk(): invalid pointer. after bisecting and looking at tree-sitter-php's makefile and nvim-treesitter's source code, I found out that if we don't include compiler flag -Os (optimize for size), then error would not occur.

from nvim-treesitter.

Please report that upstream; a valid compiler flag should not lead to a segfault. (Also, try a newer gcc, or clang.)

from nvim-treesitter.

Fixed in tree-sitter/tree-sitter-php@27afeb0

from nvim-treesitter.

Thank you all for your involvement. After fixing the parser built by nvim-treesitter works for me as expected.

from nvim-treesitter.

Thanks all for the work! Any pointers (no pun intended) as to how to manually update the php parser now that it’s fixed? :TSUpdate says all parsers are up-to-date but the crash is still happening so I’m guessing the fix hasn’t made it yet to nvim-treesitter. (real neovim noob here)

from nvim-treesitter.

@sylbru first check paths to generated php (php_only) binaries on :che vim.treesitter view (modification times). Try uninstalling and installing the parser again. I assume that you have nvim-treesitter up to date, otherwise you can still get outdated parser library.

from nvim-treesitter.