Giter VIP home page Giter VIP logo

Comments (14)

MahouShoujoMivutilde avatar MahouShoujoMivutilde commented on September 27, 2024 2

Point is that at 0.9.5 (Arch) 19ac9e8 works fine, while 3d268f9 breaks on my config with a similar error, while 7b6aefa fixes it.

Considering the issue was made about 20 minutes after the 3d268f9 but before the fix seems like a reasonable remark to me, as a counterpoint to you dismissing it.

It's okay to make mistakes, no need to get defensive about it. You fixed it, and fast, so it's fine.

from nvim-treesitter.

lukebarton avatar lukebarton commented on September 27, 2024 1

My point is, as you probably suspect, you've just treated this guy like an idiot, closed his issue and silently shipped a fix for the bug that you shipped which probably caused all of these errors, and continued to treat him like an idiot. Turn your screen off and look at your reflection in it for a minute.

Edit: and yes, as @MahouShoujoMivutilde says, shipping the bug here is not the issue. Silently fixing it and treating this person this way is.

from nvim-treesitter.

lucario387 avatar lucario387 commented on September 27, 2024

I'm not sure how it's calling vim.iter here when you're on 0.9 ...

from nvim-treesitter.

realhackcraft avatar realhackcraft commented on September 27, 2024

here is the result of cat lazy-lock.json in case it's useful:

{
  "Comment.nvim": { "branch": "master", "commit": "0236521ea582747b58869cb72f70ccfa967d2e89" },
  "LuaSnip": { "branch": "master", "commit": "03c607c2bd4db0238d8f93a6393ffbd931466390" },
  "NvChad": { "branch": "v2.5", "commit": "156eeef8ecae812acd79d5eb58070d734a6202c6" },
  "base46": { "branch": "v2.5", "commit": "a2bd5e8896fc7b6110e62dc4efdb3bf0f077baed" },
  "cmp-buffer": { "branch": "main", "commit": "3022dbc9166796b644a841a02de8dd1cc1d311fa" },
  "cmp-nvim-lsp": { "branch": "main", "commit": "39e2eda76828d88b773cc27a3f61d2ad782c922d" },
  "cmp-nvim-lua": { "branch": "main", "commit": "f12408bdb54c39c23e67cab726264c10db33ada8" },
  "cmp-path": { "branch": "main", "commit": "91ff86cd9c29299a64f968ebb45846c485725f23" },
  "cmp_luasnip": { "branch": "master", "commit": "05a9ab28b53f71d1aece421ef32fee2cb857a843" },
  "conform.nvim": { "branch": "master", "commit": "00f9d91391b04b1935e2f15948bd96cc111e7d3a" },
  "friendly-snippets": { "branch": "main", "commit": "dd2fd1281d4b22e7b4a5bfafa3e142d958e251f2" },
  "gitsigns.nvim": { "branch": "main", "commit": "805610a9393fa231f2c2b49cb521bfa413fadb3d" },
  "indent-blankline.nvim": { "branch": "master", "commit": "171d4d5a1560ccb556e94aa6df7e969068384049" },
  "lazy.nvim": { "branch": "main", "commit": "05240b41548c4245a04d34ee54f789e824129991" },
  "markdown-preview.nvim": { "branch": "master", "commit": "a923f5fc5ba36a3b17e289dc35dc17f66d0548ee" },
  "mason-lspconfig.nvim": { "branch": "main", "commit": "9ae570e206360e47d30b4c35a4550c165f4ea7b7" },
  "mason.nvim": { "branch": "main", "commit": "49ff59aded1047a773670651cfa40e76e63c6377" },
  "nvim-autopairs": { "branch": "master", "commit": "b0b79e42a28f09719a7da9534c3731fa37319d9b" },
  "nvim-cmp": { "branch": "main", "commit": "5260e5e8ecadaf13e6b82cf867a909f54e15fd07" },
  "nvim-colorizer.lua": { "branch": "master", "commit": "85855b38011114929f4058efc97af1059ab3e41d" },
  "nvim-lspconfig": { "branch": "master", "commit": "a284b14b3a9c4851f900286cd7eb68e3a8f90b1c" },
  "nvim-tree.lua": { "branch": "master", "commit": "2bc725a3ebc23f0172fb0ab4d1134b81bcc13812" },
  "nvim-treesitter": { "branch": "master", "commit": "3d268f9db4e3b1bf8ba1de792407fe89ed1274db" },
  "nvim-web-devicons": { "branch": "master", "commit": "e37bb1feee9e7320c76050a55443fa843b4b6f83" },
  "plenary.nvim": { "branch": "master", "commit": "08e301982b9a057110ede7a735dd1b5285eb341f" },
  "telescope.nvim": { "branch": "master", "commit": "bbdbb7593f832c02922075ee57d0681df30d5ee0" },
  "transparent.nvim": { "branch": "main", "commit": "fd35a46f4b7c1b244249266bdcb2da3814f01724" },
  "ui": { "branch": "v2.5", "commit": "4f507775f3935a39d994e7a1d3688e30f7fb8713" },
  "vim-fugitive": { "branch": "master", "commit": "19ca61c78c86a2ce6a425aee9b1c6664e5149ea6" },
  "vim-tabby": { "branch": "main", "commit": "afd76df166ed0f223ede1071e0cfde8075cc4a24" },
  "which-key.nvim": { "branch": "main", "commit": "4433e5ec9a507e5097571ed55c02ea9658fb268a" }
}

from nvim-treesitter.

clason avatar clason commented on September 27, 2024

Duplicate of #3092

(And obviously test with only this plugin before reporting an issue for it -- we can't debug your config for you.)

from nvim-treesitter.

realhackcraft avatar realhackcraft commented on September 27, 2024

I can't run :TSInstall!. It also give me an error:

Failed to source /Users/Borui/.local/share/nvim/lazy/nvim-treesitter/plugin/nvim-treesitter.lua

from nvim-treesitter.

clason avatar clason commented on September 27, 2024

Sounds like your installation is broken.

from nvim-treesitter.

realhackcraft avatar realhackcraft commented on September 27, 2024

Sounds like your installation is broken.

Which part of the installation? I'm not familiar yet with nvim.

from nvim-treesitter.

realhackcraft avatar realhackcraft commented on September 27, 2024

I uninstalled and reinstalled nvim-treesitter again. in the :Lazy pane I now get:

...hare/nvim/lazy/lazy.nvim/lua/lazy/manage/task/plugin.lua:59: Error while parsing command line: E492: Not an editor command: TSUpdate

from nvim-treesitter.

clason avatar clason commented on September 27, 2024

Then you should start things slowly and not install every plugin (especially this one, which is still considered experimental!)

from nvim-treesitter.

lukebarton avatar lukebarton commented on September 27, 2024

So 7b6aefa wasn't anything to do with this then?

Given

I'm not sure how it's calling vim.iter here when you're on 0.9 ...

I'd say it is likely? And I'm having this exact issue.

from nvim-treesitter.

clason avatar clason commented on September 27, 2024

That issue was fixed, so what's your point? (Seriously asking.) The remaining errors are off-topic here.

from nvim-treesitter.

clason avatar clason commented on September 27, 2024

We are talking about two different things here: the faulty guard (which was my fault, and I fixed it as quickly as possible), and the many other unrelated issues that are being reported in the same context. You will also notice that I was not the one making the comment you quote.

And let me be clear here: you have zero standing to be offended on other people's behalf; I don't see you having pointed out the problem or made a PR or even provided any constructive information to help. I'm trying hard to keep this (and several other) plugins afloat beside dealing with Neovim core issues -- all on top of my full time job.

from nvim-treesitter.

lukebarton avatar lukebarton commented on September 27, 2024

I'm well aware that you didn't make the comment I quoted. I'm glad you fixed the faulty guard as quickly as possible -- thank you for that.

You fixed my issue when you fixed the faulty guard, so I didn't need to make a separate issue. This OP was already running into the the exact problem I was having, for which @lucario387 immediately pointed out a smoking gun, which I'm sure prompted you to correct the mistake that you made - that's cool. I literally saw it fixed in real-time in front of my own eyes - awesome.

What really sucked though is how you treated the OP throughout, lacking the humility to say "Hang on, actually I just fixed something that could have caused at least part of this, can you try updating to the latest?" and instead, continuing to show little respect for someone unfamiliar with something you're an expert in and specifically, without mentioning a potentially crucial fix you just pushed, that could have solved half of, if not all of the OP's problem.

And it doesn't matter how many OSS projects you maintain (and thank you) - but you really have zero standing to expect a free pass at acting like a jerk to others, and that's why I've chimed in. I'm done now. I've said my piece, thank you for fixing the issue, thank you for maintaining all this cool software, just remember it's okay to make mistakes, and own up to them if you see someone encountering them and doing so would actually help them, which in this case, it could easily have.

from nvim-treesitter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.