Giter VIP home page Giter VIP logo

Comments (6)

marcindulak avatar marcindulak commented on August 22, 2024 1

I'm closing the issue, since the build using two patches #950 (comment) suceeded (the build link is in bugzilla).

from nwchem.

edoapra avatar edoapra commented on August 22, 2024

Fixes for the Py_SetProgramName issue have already been committed and tested on ubuntu.
c6851de
bc18d20
I am not quite sure about the origin of the Fedora failure.

from nwchem.

edoapra avatar edoapra commented on August 22, 2024

I am trying to understand this issue.
Are you asking for a new hotfix release (e.g. 7.2.3) with the existing python fixes from the master and hotfix/release-7-2-0 branches?
The patch for the 7.2.0 branch is already have available as https://github.com/nwchemgit/nwchem/commit/997856ea3e784f2e1c25a094005421ca0e064347.patch

from nwchem.

edoapra avatar edoapra commented on August 22, 2024

This updated Dockerfile shows the use of the two necessary patches

FROM python:3.13.0a3

RUN set -x \
    && apt-get update \
    && apt-get install -y git gcc python3-dev libglobalarrays-dev curl bzip2 patch

RUN set -x \
    && curl -LJO https://github.com/nwchemgit/nwchem/releases/download/v7.2.2-release/nwchem-7.2.2-release.revision-74936fb9-srconly.2023-11-03.tar.bz2 \
    && tar xjf nwchem*bz2 \
    && rm nw*bz2

RUN set -x \
    && apt-get update

RUN set -x \
    && cd nwchem*    \
    && curl  https://github.com/nwchemgit/nwchem/commit/997856ea3e784f2e1c25a094005421ca0e064347.patch | patch -p1 \
    && curl https://github.com/nwchemgit/nwchem/commit/bc18d20d90ba1fd6efc894558bef2fdacaac28a8.patch | patch -p1 \
    && cd src/python \
    && export CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer' \
    && gcc $(pkg-config --cflags --libs python3) $CFLAGS -Werror -c task_python.c

CMD ["/bin/bash"]

from nwchem.

edoapra avatar edoapra commented on August 22, 2024

Contrary to comment #950 (comment), a second patch is needed (present in master but not in hotfix/release-7-2-0) and a PR for it is in progress

from nwchem.

edoapra avatar edoapra commented on August 22, 2024

Pull request #951 merged into the hotfix/release-7-2-0 branch

from nwchem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.