Cannot read property 'domains' of undefined about domain-monitor HOT 17 CLOSED

It's probably another improperly coded promise chain on my part. I will duplicate on my end and see what I discover

from domain-monitor.

Awesome - thanks for the fixes! Really appreciate it.

Just added a bunch of domains - now waiting for the app to pull whois.

https://domain-monitor.jensen.ovh/#

from domain-monitor.

I got it to reproduce, so I will figure this out

from domain-monitor.

I believe this is fixed, if you can verify. After making the changes I pulled in I no longer get the error you listed.

This update should be live on the docker hub image.

from domain-monitor.

Thanks - the error no longer seems to be popping up, but the domains don't seem to be updating from the second record onwards.
Steps:

• Add florianjensen.com
• Remove 2 demo domains
• Add jensen.com

The first domain will get the whois info stored and update status, but the second only updates after a redeploy (keeping config) and then ends with: Waiting for WHOIS update from server

Only other error I can find in the log (although I'm not sure it's related) is:

domain-monitor    | (node:1) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'map' of undefined
domain-monitor    |     at sendCachedWHOISData (/app/lib/sockets.js:25:22)
domain-monitor    |     at /app/lib/sockets.js:147:9
domain-monitor    | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

I'm running it on: https://domain-monitor.jensen.ovh

from domain-monitor.

Found the issue, when the whois data for jensen.com was being stored, it was being stored as it's listed in the whois result. In this case, it was all caps JENSON.COM but when I store references to and build the webpage for the domains, I lowercase them (or they can be lowercased). Anyway, after manually changing the domain_name value in jensen.com.yaml it loaded and so did the rest of the page.

I modified the code to store domain_name in the cached whois data as lowercase, which should match what the frontend webpage expects to receive. After these changes, I was able to run the code fresh and follow your steps and have things successful.

from domain-monitor.

docker images have been updated

from domain-monitor.

I think it will catch them 24 hours later if you added the domains > 1min after starting the service. I don't think I have it set up to check the domains immediately after adding them. Once the domains are listed in domains.yaml, it will catch them on it's 1min check after startup.

from domain-monitor.

Alright - making progress :)
Sadly it seems that after 24 hours some of the domain names are just not loading anymore at all.

from domain-monitor.

Does the web console list any errors?

from domain-monitor.

Sadly not. No errors in there :/

from domain-monitor.

Fixed in 0.3.1

There were some issues with reading files that somehow didn't surface before. I have tested myself and it seems fixed so let me know if this fixes the issues you're seeing.

from domain-monitor.

Still seems to be stuck. I think it could be to do with jensen.eu as the domain is the only one missing (probably undefined) in this log:

domain-monitor    | 2021-08-01T17:53:35.689521919Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | connection
domain-monitor    | 2021-08-01T17:53:35.694088947Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | sent config
domain-monitor    | 2021-08-01T17:53:35.696139777Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | sent domains
domain-monitor    | 2021-08-01T17:53:35.703677957Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for florianjensen.com
domain-monitor    | 2021-08-01T17:53:35.709208333Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for flosoft.biz
domain-monitor    | 2021-08-01T17:53:35.713062471Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for jensen.com
domain-monitor    | 2021-08-01T17:53:35.715339107Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for undefined
domain-monitor    | 2021-08-01T17:53:35.717463971Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for jensen.io
domain-monitor    | 2021-08-01T17:53:35.719582064Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for jensen.me
domain-monitor    | 2021-08-01T17:53:35.722852584Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for jensen.net
domain-monitor    | 2021-08-01T17:53:35.725899147Z ::ffff:172.28.0.5 - WS client sAVlAvOF-NnkSlj_AAAN | Sent WHOIS for jensen.org

I've attached the config and whois files as well as my docker-compose.yml here.
dm-backup.tar.gz

from domain-monitor.

Confirmed that removing jensen.eu does the trick.

from domain-monitor.

I think I see the problem already. I'm doing to try running the fix on your provided backup (thanks!).

from domain-monitor.

The parser does not like how the whois comes back from the eu domain. I'll probably write a second parser and direct the results there for eu (and any other found in the future which don't follow the convention of ^key: value$

from domain-monitor.

Should be fixed, published to :latest and :0.3.2.

I recommend removing jensen.eu.yaml from your whois-data so that we know it will re-create it. The error that was occurring was happening because the parser was unable to find a domain_name to put into the yaml and that broke things. If it can't find a domain_name in the WHOIS data now, it will just return empty and the server already knows to handle that (it will put an error in the log for this).

I didn't write a new parser, just a per-processor that dissects the WHOIS data if it detects indented values.

from domain-monitor.