WorkspaceEdit contains both changes and documentChanges about purescript-language-server HOT 2 CLOSED

I just went through the specification out of curiosity, and found this text at https://microsoft.github.io/language-server-protocol/specification#workspaceedit

The edit should either provide changes or documentChanges. If the client can handle versioned document edits and if documentChanges are present, the latter are preferred over changes.

My understanding is that the server should send out at least one of changes or documentChanges.

This is because the second statement implies that if documentChanges are present, they should be preferred. There is no restriction that one of them should be null.

I think that the fix made to the client is the correct one.

from purescript-language-server.

You're right.

from purescript-language-server.