Apply all suggestions broken for certain imports about purescript-language-server HOT 4 CLOSED

I think I have it in 3fb5f18

from purescript-language-server.

I think this happens in the following combination:

There's both an unnecessary import for a data constructor and some unused functions on the same line ((..) and fromMaybe are unnecessary in this example):

import Data.Maybe (Maybe(..), fromMaybe)

example :: Maybe String -> Maybe String
example = identity

🔝 breaks.

When they occur in isolation it works (only fromMaybe is redundant here):

import Data.Maybe (Maybe(..), fromMaybe)
import PscIdeClient (compileCode)

example :: Maybe String -> Maybe String
example _ = Just ""

as well as (only (..) is redundant here)

import Data.Maybe (Maybe(..), fromMaybe)

example :: Maybe String -> Maybe String
example = identity

example2 = fromMaybe

work.

from purescript-language-server.

After more investigation something surprising happens for the first example when specifying: "Apply suggestion" on the line in question. It does what it should and leaves us with:
import Data.Maybe (Maybe) the same is true for "Remove unused reference". It also produces the complete correct result.

from purescript-language-server.

PR #78 fixes this case for me, but the following fails:

import Data.Maybe (Maybe(..), fromMaybe)
import Data.Maybe (Maybe(..), fromMaybe)

example :: Maybe String -> Maybe String
example = identity

I think this is just due to overlaps being prohibited, in this case they are still present due to not being simple duplicates. It's clear in the LSP spec that overlaps are not permitted, but I think either earlier versions of vscode allowed this or the other form of edit in the earlier LSP spec did so.

from purescript-language-server.