Giter VIP home page Giter VIP logo

Comments (4)

ayushmanchhabra avatar ayushmanchhabra commented on June 8, 2024 1

@LostBeard My thinking is we can tweak the caching implementation for NW.js binaries.

Current implementation:

Assume options.cache is enabled, options.ffmpeg is enabled and options.mode is build.

  • Download nwjs and ffmeg files.
  • Decompress nwjs and ffmpeg files into options.cacheDir.
  • Remove existing compressed nwjs and ffmpeg files.
  • Copy nwjs from options.cacheDir to options.outDir.
  • Copy options.srcDir to options.outDir.
  • Replace nwjs ffmpeg with community ffmpeg build.

Now options.ffmpeg is disabled.

  • Copy nwjs from options.cacheDir to options.outDir.
  • Copy options.srcDir to options.outDir.
  • Community ffmpeg build is not replaced.

Proposed implementation:

Assume options.cache is enabled, options.ffmpeg is enabled and options.mode is build.

  • Download nwjs and ffmeg files.
  • Decompress nwjs and ffmpeg files into options.cacheDir.
  • Remove existing compressed nwjs and ffmpeg files.
  • Copy nwjs from options.cacheDir to options.outDir.
  • Copy options.srcDir to options.outDir.
  • Replace nwjs ffmpeg with community ffmpeg build.

Now options.ffmpeg is disabled.

  • Decompress nwjs and replace existing in options.cacheDir. (Do not decompress community ffmpeg)
  • Copy nwjs from options.cacheDir to options.outDir.
  • Copy options.srcDir to options.outDir.

What do you think?

from nw-builder.

ayushmanchhabra avatar ayushmanchhabra commented on June 8, 2024

https://github.com/nwjs/npm-installer#retrieve-binaries-from-custom-download-location-or-file-path
This would also allow nw npm package to treat the options.cacheDir as a local file server.

from nw-builder.

ayushmanchhabra avatar ayushmanchhabra commented on June 8, 2024

We will also be able to retry decompression on central directory not found ZIP error.

from nw-builder.

LostBeard avatar LostBeard commented on June 8, 2024

Those changes look good. 👍

from nw-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.