Comments (4)
@LostBeard My thinking is we can tweak the caching implementation for NW.js binaries.
Current implementation:
Assume options.cache
is enabled, options.ffmpeg
is enabled and options.mode
is build
.
- Download nwjs and ffmeg files.
- Decompress nwjs and ffmpeg files into
options.cacheDir
. - Remove existing compressed nwjs and ffmpeg files.
- Copy nwjs from
options.cacheDir
tooptions.outDir
. - Copy
options.srcDir
tooptions.outDir
. - Replace nwjs ffmpeg with community ffmpeg build.
Now options.ffmpeg
is disabled.
- Copy nwjs from
options.cacheDir
tooptions.outDir
. - Copy
options.srcDir
tooptions.outDir
. - Community ffmpeg build is not replaced.
Proposed implementation:
Assume options.cache
is enabled, options.ffmpeg
is enabled and options.mode
is build
.
- Download nwjs and ffmeg files.
- Decompress nwjs and ffmpeg files into
options.cacheDir
. Remove existing compressed nwjs and ffmpeg files.- Copy nwjs from
options.cacheDir
tooptions.outDir
. - Copy
options.srcDir
tooptions.outDir
. - Replace nwjs ffmpeg with community ffmpeg build.
Now options.ffmpeg
is disabled.
- Decompress nwjs and replace existing in
options.cacheDir
. (Do not decompress community ffmpeg) - Copy nwjs from
options.cacheDir
tooptions.outDir
. - Copy
options.srcDir
tooptions.outDir
.
What do you think?
from nw-builder.
https://github.com/nwjs/npm-installer#retrieve-binaries-from-custom-download-location-or-file-path
This would also allow nw
npm package to treat the options.cacheDir
as a local file server.
from nw-builder.
We will also be able to retry decompression on central directory not found
ZIP error.
from nw-builder.
Those changes look good. 👍
from nw-builder.
Related Issues (20)
- unzipper failed. Emitted 'error' event on DuplexWrapper instance at #289 HOT 8
- nw-builder 4.5.3 requires WINE on Windows 11 HOT 3
- Add documentation on how to use package HOT 1
- Migrate back to `yauzl-promise` for unzipping MacOS binaries HOT 1
- Use Google's Release Please bot to automate releases HOT 1
- nw-builder always redownloads nw.js binaries HOT 2
- PR test coverage requirement HOT 5
- Cant use nwbuild HOT 4
- v0.87.0 MacOS builds don't launch with nw-builder v4.7.4 HOT 5
- Download manifest seems to not be cached, which leads to failures when builds are run in parallel HOT 2
- libffmpeg not being installed into correct folder HOT 5
- on some macOS, symbolic links are copied as files and link is lost
- Symlinks are copied as files on decompress HOT 9
- `argv` is not properly handled
- linux platform builds with ffmpeg enabled fail with zlib error '[ ERROR ] incorrect header check' HOT 2
- Rename MacOS Helpers HOT 3
- Node Native Addon (gyp, nan, cmake, ffi)
- Canary builds HOT 1
- nw-builder download stuck HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nw-builder.