modularity and middleware with proxies about observer-util HOT 4 OPEN

I see you have been busy the last couple of days 😄 I will check out your libs tomorrow (going to sleep now).

Double wrapping with Proxies is not that bad and I used in my previous projects. I can't find my related JSPerf snippets, but once you use Proxies it doesn't really matter how many times you wrap from my experience. We should make a new JSPerf test with double and triple wrapping though to make sure.

Also the only thing that may be problematic with double wrapping is the receiver argument in some traps, but I think it won't cause any problems. I will add some double wrapping tests to this lib later this week.

from observer-util.

I checked your libs and they are pretty awesome, I love they fit together 👍 I am not sure I understand this part though.

in playing with immutator and morphable, for example, i found that i needed to unwrap the immutator and observable proxy layers (i ended up choosing a different interface for accessing the underlying target than you did in observer-util). line 4 in the example for immutator is residual of this.

Where did you use raw in your code after you defined it?

Another side note: I would always use the matching Reflect method in Proxy traps with all the arguments - including receiver. It makes sure to correctly forward the trapped operation (even in exotic cases of double Proxy wrapping and prototypal inheritance).

from observer-util.

Thanks for the rec, I'll read up on Reflect.

_.raw is used internally by morphable to access raw state. Normally it just uses the observer-util raw function. The trouble is, by double wrapping, morphable needs to know how to unwrap the immutator proxy first. line 4 is my inelegant solution to this -- configuration for the two libraries to work together. Without it, morphable doesn't get back the raw object it expects and doesn't work properly.

from observer-util.

Oh I get it! Your solution might be more elegant actually 😄 Storing the raw object in a property instead of a WeakMap might solve the raw() - double wrapping interaction issue. I have to think about this a bit, I don't want to say something stupid.

Thanks for the discussion btw 🙂 This is something that should be solved.

from observer-util.