Comments (1)
Instead of LogDebugMsg
, I'd be fine with perhaps making LogMsg
an "info" or "debug" level log by default as it's set up to not pass anything more than a simple informational message with no other values.
In the same vein, I've found myself often abusing the Msg
fields to look like: kit.LogMsg(ctx, fmt.Sprintf("bad blah: %#v", bleh))
, which is a bad habit as we should be using structured logging properly to pass information.
To push folks away from using using the "message" field for the kitchen sink, I wonder if we should expose the additional funcs like kit.ErrorLogger(ctx).Log("message", "bad blah", "blah", bleh)
instead?
Another thought, if we want to cut out the use of the magic "message" key above, we could make a func WithMsg(log.Logger, string) log.Logger
function? Seems a bit builder-pattern-y to me, but could work?
from gizmo.
Related Issues (20)
- gizmo/server is bloated HOT 2
- Deprecated Types Should Have Been Removed Before 1.0 HOT 1
- server/kit does not flush its stack driver exporter HOT 2
- Remove Deprecated Prometheus - Use OpenCensus Instead HOT 1
- Let The User Pass A Server Mux To SimpleServer HOT 1
- Potential TimeSeries Race/Error With StackDriver HOT 3
- Drop "stdlib" Router HOT 1
- The NYTimes GitHub org will be renamed to nytimes HOT 1
- Hold monitoredresource.Autodetect() response from opencensus lib HOT 1
- aws.subscriber not thread safe HOT 4
- Build errors without using modules HOT 4
- Expose GCP PubSub PublishSettings as a configuration option HOT 1
- Dependabot can't parse your go.mod
- Can't modify existing AWS configuration for pubsub
- Dependabot can't resolve your Go dependency files
- Build errors HOT 2
- [Question] What microservices patterns are supported or implemented?
- Dependabot can't resolve your Go dependency files
- support PATCH method in CORShandler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gizmo.