Comments (4)
then, MAXNUM value constraint ("use only 128 bits of uint to prevent mul overflows.")
should be reconsidered for integer multiplication and division error.
from itt.
The base unit is uint 1 and the decimalPlaces
is only utilised by the client. It's up to the client to handle the fractional maths. No divisions are used in the contract at all to avoid rounding errors.
from itt.
But I think safe division can be performed by restricting token amount and ether price parameter.
(restricting that ether price and token aboumt value should have trailing decimal (decimalplaces/2) zeros
for example, If decimal-places is 18, token amount value and ether price value should have 9 trailing decimal zeros..
And I hope decimal places of Token might be fixed to constant(=18) same as Ether.
from itt.
There's simply no need to use fixed-point maths when you have no divides.
from itt.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itt.