Giter VIP home page Giter VIP logo

Comments (4)

ploxiln avatar ploxiln commented on May 17, 2024

If using with redirects, the path to be validated should be the redirect path

I think more explanation is needed.

It sounds like you're using the auth_request mode, possibly with kubernetes nginx ingress?

If the user tries to access (or follows a link to) example.com/actual/app and it is not whitelisted, then oauth2_proxy returns a 40x for the auth_request, and nginx redirects to /oauth2/sign_in or /oauth2/start?rd=... and they have to sign in before being redirected to /actual/app.

However, if example.com/actual/app is whitelisted, they should never get the redirect, they should go right through on the first attempt.

from oauth2-proxy.

tlawrie avatar tlawrie commented on May 17, 2024

So what we are seeing in the logs is that whilst we set the pattern to be, for example, /health the path being compared to is always the /oauth/auth path that is coming from the NGINX Controller.

When using this parameter with the Kubernetes Ingress Controller it would mean that it needs to check the rd= path and not the req.URL.Path

from oauth2-proxy.

ploxiln avatar ploxiln commented on May 17, 2024

Ah, right, if doing auth_request then the actual request path is normally not included anywhere in the auth request. (The "rd" parameter has never been used for the /oauth2/auth endpoint.) If you're doing auth_request from an nginx config, then you can have some location blocks with no auth pretty easily. For Kubernetes ingress, I don't know.

from oauth2-proxy.

github-actions avatar github-actions commented on May 17, 2024

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

from oauth2-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.