Giter VIP home page Giter VIP logo

Comments (4)

igr avatar igr commented on May 21, 2024

Yeah, you are right. Actually, there are two use cases with this.

  1. using Lagarto for their own HTML code (either directly or via other frameworks) - they probably would like to be warned that some HTML is not looking nice
  2. using Lagarto for external HTML content - they probably would like just to be informed that some HTML sucks 😄

One question: you would still like to have them in the logs, i.e. you dont want to turn off the logging for the Lagarto package?

I am thinking in even adding the property for this 😄 so user can decide the log level of the error message.

As a workaround you may use your own implementation of the LagartoDOMBuilderTagVisitor that has method error() overridden - if I am not mistaken, this one error is used for all error reporting.

WDYT about the custom property?

from jodd.

slandelle avatar slandelle commented on May 21, 2024

Basically, some users are not even able to configure logback properly, so I try to keep things as simple as possible and enable warn by default.

I agree, the best would be to be able to tell malformed HTML messages and other messages apart so they don't end up in the same sink.

👍 for the custom property

from jodd.

igr avatar igr commented on May 21, 2024

Custom property added for LagartoDomBuilder: parsingErrorLogLevelName.

Usage:

    Jerry.JerryParser jerryParser = new Jerry.JerryParser();
    LagartoDOMBuilder lagartoDOMBuilder = (LagartoDOMBuilder) jerryParser.getDOMBuilder();
    lagartoDOMBuilder.setParsingErrorLogLevelName("INFO");
    Jerry doc = jerryParser.parse(html);

Hope this helps!

from jodd.

slandelle avatar slandelle commented on May 21, 2024

Cool, thanks!

from jodd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.