Add a function to Object.prototype cause Plot to generate empty chart about plot HOT 5 CLOSED

It's a really intriguing bug. If you set Object.prototype._hello = "x"; and try the first test plot (aaplBollinger), it draws 1 line on the y axis. If you set Object.prototype._hello = "xxxxx" it draws 5 lines!

It could happen on any of the many places in our code where we iterate on an object's keys with for (key in object).

I don't think there is anything to fix here, but I'm curious as to where this happens.

from plot.

That is in order to get most natural grammar by patch functions to prototype.

For example, the function pick in underscore use.

_.pick({name: 'moe', age: 50, userid: 'moe1'}, 'name', 'age');

And in ramda, it use

R.pick(['a', 'd'], {a: 1, b: 2, c: 3, d: 4}); 

I would argue that the most natural way shall be either

{a: 1, b: 2, c: 3, d: 4}.pick(['a', 'b'])

or

{a: 1, b: 2, c: 3, d: 4}.pick('a', 'b')

from plot.

You shouldn’t modify global prototypes such as Object.prototype. All bets are off when you do that!

from plot.

Thanks a lot @Fil and @mbostock for clarification. Does D3 has this prerequisite as well?

from plot.

Like I said, all bets are off. There’s no way of knowing how any library will behave if you start modifying global prototypes.

from plot.