Symlinks on Vagrant running on Windows about pre-commit HOT 8 OPEN

Sorry for digging up this old issue, but I believe my PR solves this issue:
#84

from pre-commit.

The reason why we're symlinking is so we can use our node_modules inside of the hook as it will properly resolve to the node_modules of this project. By copying, we would lose all the functionality again making the codebase super hard to maintain and update. But if you know ways around and can create a working pull request, i'll be more than happy to merge that in.

from pre-commit.

That's true, I haven't thought about that. I'm gonna play with it over the weekend.

from pre-commit.

I don't think this is an issue only for Windows users, I would expect this to affect anyone using Vagrant or similar. The symlink it creates doesn't use relative paths, so I need to recreate it anyway.

I can't tell if this works on Windows (but I suspect it doesn't), but in the Vagrant instance I remove the symlink created and create another one either using ln -rs node_modules/pre-commit/hook .git/hooks/pre-commit or ln -s '../../node_modules/pre-commit/hook' .git/hooks/pre-commit and then I can run it outside Vagrant as the link gets resolved correctly.

from pre-commit.

@g-p-g So your suggestion is change symlinks to use relative paths instead of full paths and that could magically fix the issue?

from pre-commit.

@3rd-Eden what do you mean by magically? I explicitly mentioned that it doesn't work for me right now, even when using Vagrant inside Linux or OSX, that is not specific to Windows. The relative path fix the problem I have.

from pre-commit.

@g-p-g Yes, sorry about. I read it incorrectly.

from pre-commit.

+1 for this issue.
As far as some team members use window - this is the only thing that prevents us from using it.

from pre-commit.