Comments (14)
On the backend, there is an option that indicates if tax is included in price or not and I think it changes this behavior. Could you check that?
from connector-magento.
I tried that before, but then I have the problem that the imported sales orders are completely wrong. Our products in Magento have prices incl. tax. The synced orders with that option calculate the tax on top of the products which already have tax incl. For example: product price is 69€ incl. tax, sales order with this product total is 82.11€ - but it should be 69€.
from connector-magento.
Pity. Getting all the options working together in all possible ways is really tricky with incl. and excl. taxes. I have no clue for that yet.
from connector-magento.
Ok, thats unfortunate. Can you tell me where you handle the tax calculations - then I'll have a look at it in the code, as the rules itself are pretty straight forward.
Is there a documentation for the connector where I can have a look how you handle various cases? I'm especially interested in the order syncing mechanism!
from connector-magento.
Here is the mapping for the discount: https://github.com/OCA/connector-magento/blob/8.0/magentoerpconnect/sale.py#L961-L972
And a test which proves to be insufficient here: https://github.com/OCA/connector-magento/blob/8.0/magentoerpconnect/tests/test_synchronization.py#L240-L266
There is no general documentation for that.
from connector-magento.
(record
in the method contains the values from Magento)
from connector-magento.
Thanks, I just had a look at the code and the problem is the self.options.tax_include parameter and how it is used. To every order that is imported from Magento, Odoo calculates the tax on top, so in our case (our prices in Magento include the tax already) if I set the parameter to yes, I would have the double tax value in Odoo, but the correct discount logic. If I set it to no, I have correct imported orders but wrong discount logic. Therefore this parameter makes no sense at the discount logic step.
from connector-magento.
@aignermi does it depend on a configuration on Magento perhaps? I know Magento had a handful of options such as compute discount after total, before taxes, ...
from connector-magento.
I mean we can remove this logic in the discount, but I don't want to break other scenario, if it was there at a first place, I think (I hope) it was working for the one who wrote this part
from connector-magento.
@guewen yep I understand that. Let me check our settings there and let me check how Magento behaves with different settings and how the base_row_total_incl_tax field is calculated then. I'll try it out by removing that section too.
from connector-magento.
if I set the parameter to yes, I would have the double tax value in Odoo
Why not set tax include taxes on the products?
from connector-magento.
Where would I set that?
from connector-magento.
By activating "Tax included in Price" in the tax of your products
from connector-magento.
Thx, that did the trick!
from connector-magento.
Related Issues (20)
- Migration to version 12.0 HOT 1
- External ID not found in the system: base.menu_config" HOT 2
- Connector-Magento for Odoo 11 HOT 2
- setting https for the connector HOT 2
- Pylint broken
- Product sync Odoo -> Magento HOT 1
- Migration to version 13.0 HOT 2
- I want to connect odoo 12 to magento 2.3.4 HOT 4
- Discount calculation HOT 1
- Migration to version 14.0
- Magento Odoo HOT 2
- Developer HOT 1
- Why commit "[IMP] Set a pricelist based on the currency of the order" fa27e776b093d3bc3a4998f2ee5a16084e964ef0
- Importing from a regular magento 1.7 gives us a TypeError.
- Who are the ones in charge of the various branchs? HOT 1
- odoo 11/12 - magento 1.9.x magento.product.category error HOT 3
- Migration to version 15.0
- How to stop/delete a Magento Backends
- Migration to version 16.0
- Migration to version 17.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connector-magento.