[10] base_multi_company _compute_company_id improvement suggestion about multi-company HOT 11 CLOSED

Please make a PR (https://odoo-community.org/page/code) rewriting it this way:

@api.multi
def _compute_company_id(self):
    for record in self:
        if self.env.user.company_id in record.company_ids:
            record.company_id = self.env.user.company_id
        else:
            record.company_id = (
                self.env.user.company_ids - record.company_ids
            )[:1]

from multi-company.

Hi, I don't understand your code? what does (self.env.user.company_ids - record.company_ids) do? it intersects the 2 lists? (I think this is what we want, the intersection of the 2 lists...)

from multi-company.

Set operation called difference

from multi-company.

But you are right. It's intersection what is needed. Please change it to self.env.user.company_ids & record.company_ids

from multi-company.

i thought the minus was overwritten by odoo or something...

from multi-company.

Well, indeed each operator can be overwritten in Python for adding your own logic about what the operation means for you, and it's done in that way with recordset, but as said, it's intersection what we want.

from multi-company.

yeah, i mean i thought the minus was overwritten in odoo to do intersection, which would be crazy, but since i'm new to python and odoo, i wasn't sure :)

from multi-company.

Sorry, my bad

from multi-company.

no problem

from multi-company.

Sorry but i think i will use the original code... record.company_ids is actually res.company.assignment. The code you suggested needs to be converted to sets and it also give me apple-orange error...

from multi-company.

Fixed after merging #91

from multi-company.