Giter VIP home page Giter VIP logo

Comments (17)

pedrobaeza avatar pedrobaeza commented on July 30, 2024

And % endif is also removed?

@antespi, you have also this issue, doesn't it?

from web.

RoelAdriaans avatar RoelAdriaans commented on July 30, 2024

@pedrobaeza %end if is not removed, it's on a new line with the next % if next to it.
I've updated my paste..

0k/web_ckeditor#4 seems to be the same issue

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

I think that has to be treated on the ckeditor4 JS widget itself, not here, but @hbrunn should say about this

from web.

hbrunn avatar hbrunn commented on July 30, 2024

To fix this, we'll have to dive into ckeditor's internals, I think. http://docs.ckeditor.com/#!/api/CKEDITOR.htmlDataProcessor seems to be a good starting point. Or this looks even better: http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-protectedSource

from web.

antespi avatar antespi commented on July 30, 2024

@pedrobaeza yes, we have the same issue.
@hbrunn yes, protectedSource regex maybe fix this.

from web.

rafaelbn avatar rafaelbn commented on July 30, 2024

@hbrunn did you detect the same issue using https://github.com/OCA/crm/tree/8.0/newsletter when creating/editing emails templates Under Sales/Configuration/Newsletter type? (as newsletter installs ckeditor)

from web.

hbrunn avatar hbrunn commented on July 30, 2024

@RoelAdriaans-B-informed @pedrobaeza @antespi @rafaelbn

I think @lfreeke mentioned this problem once.

Should be fixed by #158

from web.

RoelAdriaans avatar RoelAdriaans commented on July 30, 2024

#158 did not fix this issue

from web.

rafaelbn avatar rafaelbn commented on July 30, 2024

As #158 didn't fix this issue, are any of you interested in fixing it? Are you using this module en production enviroments? We are still not using this module as corrupts many standards functionalities.

from web.

rafaelbn avatar rafaelbn commented on July 30, 2024

Check #213 @hbrunn update ckeditor version

from web.

rafaelbn avatar rafaelbn commented on July 30, 2024

@sergio-incaser @carlos-incaser as you are using web_ckeditor4 module I think you are interested in this issue. We are not using web_ckeditor4 by the moment. We need time to fix this issue and test it deeper to use with customers.

from web.

psyray avatar psyray commented on July 30, 2024

Hi,
This bug is still present, result after saving is the same as @RoelAdriaans-B-informed reports.
image
image

Is this planned to be resolved ?

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

If the PR already merged doesn't resolve it, I don't think so, as most of us have moved on to 9.0 or uninstall the module, but I can't speak for all.

from web.

psyray avatar psyray commented on July 30, 2024

Thanks for quick reply ;)
Is there a way to disable ck_editor for email templating ? Or must i use this module for all html content ?

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

Not now AFAIK, as this one replaces default HTML editor.

from web.

psyray avatar psyray commented on July 30, 2024

Ok thanks, I will disable this module.

from web.

github-actions avatar github-actions commented on July 30, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.