Giter VIP home page Giter VIP logo

Comments (13)

dreispt avatar dreispt commented on July 30, 2024 1

@lasley that's what it's like to work in community 😉

from web.

hbrunn avatar hbrunn commented on July 30, 2024

This should amount to a module that puts <link rel="shortcut icon" ... in the template website.layout. This could read the current (current as in the website's) company for the icon itself. But without multi website, you'll be stuck with the company your website isl inked to.

from web.

hbrunn avatar hbrunn commented on July 30, 2024

PS: I think this is an issue for https://github.com/OCA/website

from web.

dreispt avatar dreispt commented on July 30, 2024

My personal "pain point" is that my browser as tabs opened in multiple Odoo environments, and a different favicon per instance (or instance/company) would be very helpful.They may not have website enable, so this would be best as a web feature.

from web.

nhomar avatar nhomar commented on July 30, 2024

@hbrunn We did ii, at the end we will need 2 modules website_favicon and web_favicon let me port what we did for www.vauxoo.com which is already working (wired in our theme but I can extract it).

It is fairly simple.

from web.

hbrunn avatar hbrunn commented on July 30, 2024

ah, then you'll need to change it in two places anyways, one web_favicon and website_favicon that depends on this

from web.

hbrunn avatar hbrunn commented on July 30, 2024

@nhomar I wrote my stuff before I saw yours, exactly that

from web.

nhomar avatar nhomar commented on July 30, 2024

jejejeje yes....

from web.

dreispt avatar dreispt commented on July 30, 2024

So, I get to choose then... 😉

from web.

lasley avatar lasley commented on July 30, 2024

I just saw this new module, which fills a gap that currently had to be custom configured. I'll go ahead and upgrade this to v9, but I was wondering if the community had any interest in retina friendly favicons?

In order to accomplish this, we would just need a few additional image fields that provide the proper scaling - similar to products with image_small, _medium, etc.

Example of retina favicons:

<!-- For third-generation iPad with high-resolution Retina display: -->
<link rel="apple-touch-icon-precomposed" sizes="144x144" href="apple-touch-icon-144x144-precomposed.png">

<!-- For iPhone with high-resolution Retina display: -->

<link rel="apple-touch-icon-precomposed" sizes="114x114" href="apple-touch-icon-114x114-precomposed.png">

<!-- For first- and second-generation iPad: -->

<link rel="apple-touch-icon-precomposed" sizes="72x72" href="apple-touch-icon-72x72-precomposed.png">

<!-- For non-Retina iPhone, iPod Touch, and Android 2.1+ devices: -->

<link rel="apple-touch-icon-precomposed" href="apple-touch- icon-precomposed.png">

If this is something the community is interested in, I will add during the 9.0 conversion + back-port for this 8.0

from web.

hbrunn avatar hbrunn commented on July 30, 2024

that's what @pedrobaeza would have liked to have had in #252, but it didn't work out. I think your code will be welcome, even though I personally couldn't care less. But you should implement it in a way that the fancy stuff isn't mandatory.

This issue is done btw, so I'll close it. Forgot that on merge time.

from web.

pedrobaeza avatar pedrobaeza commented on July 30, 2024

Hi, @lasley, I have already migrated the module to v9. Please check #344. About retina display icons, please check the Known issues section, where I took into account that. In /static/src/img I have put image samples and HTML basic configuration also for all the possibilities.

from web.

lasley avatar lasley commented on July 30, 2024

Copy, thanks for the insight @hbrunn

Hooray I love it when work I am planning is already done! I'll check into your PR right now, thanks @pedrobaeza

from web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.